Unverified Commit 1be7fe5e authored by toonn's avatar toonn Committed by GitHub
Browse files

nb: Use bashInteractive to fix shell subcommand (#375817) 

The `nb shell` subcommand relies on Bash's `read` and the default Bash
in stdenv has unexpected behavior, characters aren't echoed and arrow
keys do not seem to recall history.

By adding `bashInteractive` to the buildInputs, patchShebangs picks it
up and this fixes the behavior.

Fixes #374606
parent cfe3cc1a

pkgs/by-name/nb/nb/package.nix

+3 −0
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
  testers,

  nix-update-script,

  nb,

  bashInteractive,

}:



stdenv.mkDerivation rec {
@@ -21,6 +22,8 @@ stdenv.mkDerivation rec { 


  nativeBuildInputs = [ installShellFiles ];



  buildInputs = [ bashInteractive ];



  dontBuild = true;



  installPhase = ''