Unverified Commit 194ddeef authored by Alyssa Ross's avatar Alyssa Ross
Browse files

wrapBintoolsWith: support LINK.EXE-style args in purity checks 

LLD supports Windows-style linker arguments, but these previously
triggered purity check false positives, because it saw that they
started with a '/' and assumed they were paths.

This tweaks the path detection to allow through certain values that
could be paths, but are much more likely to be LINK.EXE-style flags.
The risk of false negatives here is low — the only things we'd now
fail to catch would be attempts to link with libraries in the root
directory, which doesn't happen in practice.

We also teach the wrapper how to apply its purity checks to library
paths specified with the /LIBPATH: option.

Tested that paths we expect to be rejected (like /lib/libfoo.so) still
are.
parent 0949f3cd

pkgs/build-support/bintools-wrapper/ld-wrapper.sh

+6 −4
Original line number Diff line number Diff line
@@ -55,10 +55,12 @@ if [[ "${NIX_ENFORCE_PURITY:-}" = 1 && -n "${NIX_STORE:-}" 
            # produces '-syslibroot //' linker flag. It's a no-op,

            # which does not introduce impurities.

            n+=1; skip "$p2"

        elif [ "${p:0:1}" = / ] && badPath "$p"; then

            # We cannot skip this; barf.

            echo "impure path \`$p' used in link" >&2

            exit 1

        elif [ "${p:0:10}" = /LIBPATH:/ ] && badPath "${p:9}"; then

            reject "${p:9}"

        # We need to not match LINK.EXE-style flags like

        # /NOLOGO or /LIBPATH:/nix/store/foo

        elif [[ $p =~ ^/[^:]*/ ]] && badPath "$p"; then

            reject "$p"

        elif [ "${p:0:9}" = --sysroot ]; then

            # Our ld is not built with sysroot support (Can we fix that?)

            :

pkgs/build-support/wrapper-common/utils.bash

+6 −1
Original line number Diff line number Diff line
@@ -90,6 +90,11 @@ skip () { 
    fi

}



reject() {

    echo "impure path \`$1' used in link" >&2

    exit 1

}





# Checks whether a path is impure.  E.g., `/lib/foo.so' is impure, but

# `/nix/store/.../lib/foo.so' isn't.