Unverified Commit 14f76a96 authored by Dan Buch's avatar Dan Buch
Browse files

fetch-yarn-deps: warn on undefined expected hash 

instead of rejecting, given that the expected hash may not be known/provided.
parent 3ffce56f

pkgs/build-support/node/fetch-yarn-deps/index.js

+3 −1
Original line number Diff line number Diff line
@@ -37,7 +37,9 @@ const downloadFileHttps = (fileName, url, expectedHash, hashType = 'sha1') => { 
			res.on('end', () => {

				file.close()

				const h = hash.read()

				if (h != expectedHash) return reject(new Error(`hash mismatch, expected ${expectedHash}, got ${h}`))

				if (expectedHash === undefined){

					console.log(`Warning: lockfile url ${url} doesn't end in "#<hash>" to validate against. Downloaded file had hash ${h}.`);

				} else if (h != expectedHash) return reject(new Error(`hash mismatch, expected ${expectedHash}, got ${h}`))

				resolve()

			})

                        res.on('error', e => reject(e))