Merge pull request #276306 from ambroisie/aria2-rpc-secret-file

- `nitter` requires a `guest_accounts.jsonl` to be provided as a path or loaded into the default location at `/var/lib/nitter/guest_accounts.jsonl`. See [Guest Account Branch Deployment](https://github.com/zedeus/nitter/wiki/Guest-Account-Branch-Deployment) for details.

- `services.aria2.rpcSecret` has been replaced with `services.aria2.rpcSecretFile`.

  This was done so that secrets aren't stored in the world-readable nix store.

  To migrate, you will have create a file with the same exact string, and change

  your module options to point to that file. For example, `services.aria2.rpcSecret =

  "mysecret"` becomes `services.aria2.rpcSecretFile = "/path/to/secret_file"`

  where the file `secret_file` contains the string `mysecret`.

- Invidious has changed its default database username from `kemal` to `invidious`. Setups involving an externally provisioned database (i.e. `services.invidious.database.createLocally == false`) should adjust their configuration accordingly. The old `kemal` user will not be removed automatically even when the database is provisioned automatically.(https://github.com/NixOS/nixpkgs/pull/265857)

- `inetutils` now has a lower priority to avoid shadowing the commonly used `util-linux`. If one wishes to restore the default priority, simply use `lib.setPrio 5 inetutils` or override with `meta.priority = 5`.

    dir=${cfg.downloadDir}

    listen-port=${concatStringsSep "," (rangesToStringList cfg.listenPortRange)}

    rpc-listen-port=${toString cfg.rpcListenPort}

    rpc-secret=${cfg.rpcSecret}

  '';

in

{

  imports = [

    (mkRemovedOptionModule [ "services" "aria2" "rpcSecret" ] "Use services.aria2.rpcSecretFile instead")

  ];

  options = {

    services.aria2 = {

      enable = mkOption {

        default = 6800;

        description = lib.mdDoc "Specify a port number for JSON-RPC/XML-RPC server to listen to. Possible Values: 1024-65535";

      };

      rpcSecret = mkOption {

        type = types.str;

        default = "aria2rpc";

      rpcSecretFile = mkOption {

        type = types.path;

        example = "/run/secrets/aria2-rpc-token.txt";

        description = lib.mdDoc ''

          Set RPC secret authorization token.

          A file containing the RPC secret authorization token.

          Read https://aria2.github.io/manual/en/html/aria2c.html#rpc-auth to know how this option value is used.

        '';

      };

          touch "${sessionFile}"

        fi

        cp -f "${settingsFile}" "${settingsDir}/aria2.conf"

        echo "rpc-secret=$(cat "$CREDENTIALS_DIRECTORY/rpcSecretFile")" >> "${settingsDir}/aria2.conf"

      '';

      serviceConfig = {

        ExecReload = "${pkgs.coreutils}/bin/kill -HUP $MAINPID";

        User = "aria2";

        Group = "aria2";

        LoadCredential="rpcSecretFile:${cfg.rpcSecretFile}";

      };

    };

  };