Unverified Commit 116ab287 authored by éclairevoyant's avatar éclairevoyant
Browse files

maintainers/fix-maintainers.pl: handle null github handles 

* use attrname in log messages instead of github handle
* don't remove users simply for empty github handles, if their user
  still exists (prevents #259555)
parent d88d7ed8

maintainers/scripts/fix-maintainers.pl

+6 −4
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ while(my($k, $v) = each %$maintainers_json) { 
    my $current_user = %$v{'github'};

    if (!defined $current_user) {

        print "$k has no github handle\n";

        next;

    }

    my $github_id = %$v{'githubId'};

    if (!defined $github_id) {
@@ -37,13 +36,16 @@ while(my($k, $v) = each %$maintainers_json) { 
        sleep($ratelimit_reset - time() + 5);

    }

    if ($resp->code != 200) {

        print $current_user . " likely deleted their github account\n";

        print "$k likely deleted their github account\n";

        next;

    }

    my $resp_json = from_json($resp->content);

    my $api_user = %$resp_json{"login"};

    if (lc($current_user) ne lc($api_user)) {

        print $current_user . " is now known on github as " . $api_user . ". Editing maintainer-list.nix…\n";

    if (!defined $current_user) {

        print "$k is known on github as $api_user.\n";

    }

    elsif (lc($current_user) ne lc($api_user)) {

        print "$k is now known on github as $api_user. Editing maintainer-list.nix…\n";

        my $file = path($maintainers_list_nix);

        my $data = $file->slurp_utf8;

        $data =~ s/github = "$current_user";$/github = "$api_user";/m;