Commit 10b2e953 authored by eveeifyeve's avatar eveeifyeve
Browse files

vesktop: fix darwin build 

Fixes https://github.com/NixOS/nixpkgs/issues/484618


Co-authored-by: default avatarLuke Davis <op_@outlook.com>
parent 2f370bd7

pkgs/by-name/ve/vesktop/package.nix

+2 −7
Original line number Diff line number Diff line
@@ -87,12 +87,6 @@ stdenv.mkDerivation (finalAttrs: { 
    ELECTRON_SKIP_BINARY_DOWNLOAD = 1;

  };



  # disable code signing on macos

  # https://github.com/electron-userland/electron-builder/blob/77f977435c99247d5db395895618b150f5006e8f/docs/code-signing.md#how-to-disable-code-signing-during-the-build-process-on-macos

  postConfigure = lib.optionalString stdenv.hostPlatform.isDarwin ''

    export CSC_IDENTITY_AUTO_DISCOVERY=false

  '';



  # electron builds must be writable

  preBuild = ''

    # Validate electron version matches upstream package.json
@@ -119,7 +113,8 @@ stdenv.mkDerivation (finalAttrs: { 
      --dir \

      -c.asarUnpack="**/*.node" \

      -c.electronDist=${if stdenv.hostPlatform.isDarwin then "." else "electron-dist"} \

      -c.electronVersion=${electron.version}

      -c.electronVersion=${electron.version} \

      ${lib.optionalString stdenv.hostPlatform.isDarwin "-c.mac.identity=null"} # disable code signing on macos, https://github.com/electron-userland/electron-builder/blob/77f977435c99247d5db395895618b150f5006e8f/docs/code-signing.md#how-to-disable-code-signing-during-the-build-process-on-macos



    runHook postBuild

  '';