Unverified Commit 0ca4e5f0 authored by Winter's avatar Winter Committed by GitHub
Browse files

stdenv.mkDerivation: warn when overriding version without also overriding src (#406535)

parents e48f0a06 2a4e829d
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ let

  luaDrv = originalLuaDrv.overrideAttrs (oa: {
    version = attrs.version or oa.version;
    __intentionallyOverridingVersion = true;
    rockspecVersion = oa.rockspecVersion;

    extraConfig = ''
@@ -43,6 +44,7 @@ let
          lua.pkgs.luarocksMoveDataFolder
        ];
        version = "${originalLuaDrv.version}-unstable-${oa.version}";
        __intentionallyOverridingVersion = true;
      }
    )
  );
+1 −0
Original line number Diff line number Diff line
@@ -67,6 +67,7 @@ let

  cef = cef-binary.overrideAttrs (oldAttrs: {
    version = "127.3.5";
    __intentionallyOverridingVersion = true; # `cef-binary` uses the overridden `srcHash` values in its source FOD
    gitRevision = "114ea2a";
    chromiumVersion = "127.0.6533.120";

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@
let
  cef = cef-binary.overrideAttrs (oldAttrs: {
    version = "126.2.18";
    __intentionallyOverridingVersion = true; # `cef-binary` uses the overridden `srcHash` values in its source FOD
    gitRevision = "3647d39";
    chromiumVersion = "126.0.6478.183";

+1 −0
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@
let
  cef = cef-binary.overrideAttrs (oldAttrs: {
    version = "120.1.10";
    __intentionallyOverridingVersion = true; # `cef-binary` uses the overridden `srcHash` values in its source FOD
    gitRevision = "3ce3184";
    chromiumVersion = "120.0.6099.129";

+1 −0
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ in
        rev = lib.last (lib.splitString "-" (lib.last rel));
      in
      "${date}-${rev}";
    __intentionallyOverridingVersion = true;

    meta.broken = luaOlder "5.1" || luaAtLeast "5.5";

Loading