Merge pull request #307450 from reckenrode/wine-fixes

with import ./util.nix { inherit lib; };

let

  patches' = patches;

  prevName = pname;

  prevPlatforms = platforms;

  prevConfigFlags = configureFlags;

  setupHookDarwin = makeSetupHook {

    name = "darwin-mingw-hook";

    substitutions = {

      mingwGccsSuffixSalts = map (gcc: gcc.suffixSalt) mingwGccs;

    };

  } ./setup-hook-darwin.sh;

  darwinUnsupportedFlags = [ "alsaSupport" "cairoSupport" "dbusSupport" "fontconfigSupport" "gtkSupport" "netapiSupport" "pulseaudioSupport" "udevSupport" "v4lSupport" "vaSupport" "waylandSupport" "x11Support" "xineramaSupport" ];

  darwinUnsupported = builtins.any (name: builtins.getAttr name supportFlags) darwinUnsupportedFlags;

  darwinFrameworks = lib.optionals stdenv.isDarwin (

    toBuildInputs pkgArches (pkgs: with pkgs.buildPackages.darwin.apple_sdk.frameworks; [

      CoreServices Foundation ForceFeedback AppKit OpenGL IOKit DiskArbitration PCSC Security

      ApplicationServices AudioToolbox CoreAudio AudioUnit CoreMIDI OpenCL Cocoa Carbon

    ])

  );

  # Building Wine with these flags isn’t supported on Darwin. Using any of them will result in an evaluation failures

  # because they will put Darwin in `meta.badPlatforms`.

  darwinUnsupportedFlags = [

    "alsaSupport" "cairoSupport" "dbusSupport" "fontconfigSupport" "gtkSupport" "netapiSupport" "pulseaudioSupport"

    "udevSupport" "v4lSupport" "vaSupport" "waylandSupport" "x11Support" "xineramaSupport"

  ];

  badPlatforms = lib.optional (!supportFlags.mingwSupport || lib.any (flag: supportFlags.${flag}) darwinUnsupportedFlags) "x86_64-darwin";

in

stdenv.mkDerivation ((lib.optionalAttrs (buildScript != null) {

  builder = buildScript;

}) // (lib.optionalAttrs stdenv.isDarwin {

  postConfigure = ''

    # dynamic fallback, so this shouldn’t cause problems for older versions of macOS and will

    # provide additional functionality on newer ones. This can be removed once the x86_64-darwin

    # SDK is updated.

    sed 's|/\* #undef HAVE_MTLDEVICE_REGISTRYID \*/|#define HAVE_MTLDEVICE_REGISTRYID 1|' \

      -i include/config.h

  '';

stdenv.mkDerivation (finalAttrs:

lib.optionalAttrs (buildScript != null) { builder = buildScript; }

// lib.optionalAttrs stdenv.isDarwin {

    postBuild = ''

      # The Wine preloader must _not_ be linked to any system libraries, but `NIX_LDFLAGS` will link

      # to libintl, libiconv, and CoreFoundation no matter what. Delete the one that was built and

        || echo "loader/$preloader not built, skipping relink."

      done

    '';

}) // rec {

}

// {

  inherit version src;

  pname = prevName + lib.optionalString (wineRelease != "stable" && wineRelease != "unstable") "-${wineRelease}";

  ++ lib.optionals openclSupport [ pkgs.opencl-headers pkgs.ocl-icd ]

  ++ lib.optionals tlsSupport    [ pkgs.openssl pkgs.gnutls ]

  ++ lib.optionals (openglSupport && !stdenv.isDarwin) [ pkgs.libGLU pkgs.libGL pkgs.mesa.osmesa pkgs.libdrm ]

  ++ lib.optionals stdenv.isDarwin (with pkgs.buildPackages.darwin.apple_sdk.frameworks; [

     CoreServices Foundation ForceFeedback AppKit OpenGL IOKit DiskArbitration PCSC Security

     ApplicationServices AudioToolbox CoreAudio AudioUnit CoreMIDI OpenCL Cocoa Carbon

  ])

  ++ lib.optionals stdenv.isDarwin darwinFrameworks

  ++ lib.optionals (x11Support) (with pkgs.xorg; [

    libX11 libXcomposite libXcursor libXext libXfixes libXi libXrandr libXrender libXxf86vm

  ])

     mesa # for libgbm

  ])));

  patches = [ ]

    ++ lib.optionals stdenv.isDarwin [

      # Wine uses `MTLDevice.registryID` in `winemac.drv`, but that property is not available in

      # the 10.12 SDK (current SDK on x86_64-darwin). That can be worked around by using selector

      # syntax. As of Wine 8.12, the logic has changed and uses selector syntax, but it still

      # uses property syntax in one place. The first patch is necessary only with older

      # versions of Wine. The second is needed on all versions of Wine.

      (lib.optional (lib.versionOlder version "8.12") ./darwin-metal-compat-pre8.12.patch)

      (lib.optional (lib.versionOlder version "8.18") ./darwin-metal-compat-pre8.18.patch)

      (lib.optional (lib.versionAtLeast version "8.18") ./darwin-metal-compat.patch)

      # Wine requires `qos.h`, which is not included by default on the 10.12 SDK in nixpkgs.

      ./darwin-qos.patch

    ]

    ++ patches';

  # Because the 10.12 SDK doesn’t define `registryID`, clang assumes the undefined selector returns

  # `id`, which is a pointer. This causes implicit pointer to integer errors in clang 15+.

  # The following post-processing step adds a cast to `uint64_t` before the selector invocation to

  # silence these errors.

  postPatch = lib.optionalString stdenv.isDarwin ''

    sed -e 's|\(\[[A-Za-z_][][A-Za-z_0-9]* registryID\]\)|(uint64_t)\1|' \

      -i dlls/winemac.drv/cocoa_display.m

  '';

  inherit patches;

  configureFlags = prevConfigFlags

    ++ lib.optionals supportFlags.waylandSupport [ "--with-wayland" ]

  # them to the RPATH so that the user doesn't have to set them in

  # LD_LIBRARY_PATH.

  NIX_LDFLAGS = toString (map (path: "-rpath " + path) (

      map (x: "${lib.getLib x}/lib") ([ stdenv.cc.cc ] ++ buildInputs)

      map (x: "${lib.getLib x}/lib") ([ stdenv.cc.cc ]

        # Avoid adding rpath references to non-existent framework `lib` paths.

        ++ lib.subtractLists darwinFrameworks finalAttrs.buildInputs)

      # libpulsecommon.so is linked but not found otherwise

      ++ lib.optionals supportFlags.pulseaudioSupport (map (x: "${lib.getLib x}/lib/pulseaudio")

          (toBuildInputs pkgArches (pkgs: [ pkgs.libpulseaudio ])))

      fromSource

      binaryNativeCode  # mono, gecko

    ];

    broken = stdenv.isDarwin && !supportFlags.mingwSupport;

    description = "An Open Source implementation of the Windows API on top of X, OpenGL, and Unix";

    platforms = if darwinUnsupported then (lib.remove "x86_64-darwin" prevPlatforms) else prevPlatforms;

    inherit badPlatforms platforms;

    maintainers = with lib.maintainers; [ avnik raskin bendlas jmc-figueira reckenrode ];

    inherit mainProgram;

  };

diff --git a/dlls/winemac.drv/cocoa_display.m b/dlls/winemac.drv/cocoa_display.m

--- a/dlls/winemac.drv/cocoa_display.m

+++ b/dlls/winemac.drv/cocoa_display.m

@@ -289,7 +289,7 @@ static int macdrv_get_gpus_from_metal(struct macdrv_gpu** new_gpus, int* count)

      * the primary GPU because we need to hide the integrated GPU for an automatic graphic switching pair to avoid apps

      * using the integrated GPU. This is the behavior of Windows on a Mac. */

     primary_device = [MTLCreateSystemDefaultDevice() autorelease];

-    if (macdrv_get_gpu_info_from_registry_id(&primary_gpu, primary_device.registryID))

+    if (macdrv_get_gpu_info_from_registry_id(&primary_gpu, [primary_device registryID]))

         goto done;

     /* Hide the integrated GPU if the system default device is a dedicated GPU */

@@ -301,7 +301,7 @@ static int macdrv_get_gpus_from_metal(struct macdrv_gpu** new_gpus, int* count)

     for (i = 0; i < devices.count; i++)

     {

-        if (macdrv_get_gpu_info_from_registry_id(&gpus[gpu_count], devices[i].registryID))

+        if (macdrv_get_gpu_info_from_registry_id(&gpus[gpu_count], [devices[i] registryID]))

             goto done;

         if (hide_integrated && devices[i].isLowPower)

diff --git a/dlls/winemac.drv/cocoa_display.m b/dlls/winemac.drv/cocoa_display.m

--- a/dlls/winemac.drv/cocoa_display.m

+++ b/dlls/winemac.drv/cocoa_display.m

@@ -354,7 +354,7 @@ static int macdrv_get_gpu_info_from_display_id_using_metal(struct macdrv_gpu* gp

     device = [CGDirectDisplayCopyCurrentMetalDevice(display_id) autorelease];

     if (device && [device respondsToSelector:@selector(registryID)])

-        ret = macdrv_get_gpu_info_from_registry_id(gpu, device.registryID);

+        ret = macdrv_get_gpu_info_from_registry_id(gpu, [device registryID]);

 done:

     [pool release];

diff --git a/dlls/winemac.drv/cocoa_display.m b/dlls/winemac.drv/cocoa_display.m

index fbbe16efcbf..2db375ff3d5 100644

--- a/dlls/winemac.drv/cocoa_display.m

+++ b/dlls/winemac.drv/cocoa_display.m

@@ -387,7 +387,7 @@ static int macdrv_get_gpu_info_from_display_id_using_metal(struct macdrv_gpu* gp

     device = [CGDirectDisplayCopyCurrentMetalDevice(display_id) autorelease];

     if (device && [device respondsToSelector:@selector(registryID)])

-        return macdrv_get_gpu_info_from_registry_id(gpu, device.registryID);

+        return macdrv_get_gpu_info_from_registry_id(gpu, [device registryID]);

     else

         return -1;

 }

diff --git a/dlls/ntdll/unix/loader.c b/dlls/ntdll/unix/loader.c

index cde37c48b0d..be237bc0ad3 100644

--- a/dlls/ntdll/unix/loader.c

+++ b/dlls/ntdll/unix/loader.c

@@ -65,6 +65,7 @@

 # undef LoadResource

 # undef GetCurrentThread

 # include <pthread.h>

+# include <pthread/qos.h>

 # include <mach/mach.h>

 # include <mach/mach_error.h>

 # include <mach-o/getsect.h>