Unverified Commit 0a07e4e1 authored by Michael Daniels's avatar Michael Daniels
Browse files

ci/github-script/lint-commits: fix development branch check 

https://redirect.github.com/NixOS/nixpkgs/pull/487628 should have had this
job fail, but [didn't](https://github.com/NixOS/nixpkgs/actions/runs/21753302803/job/62756645701?pr=487628#step:3:18),
because the head branch was named `master`.
parent aa737833

ci/github-script/lint-commits.js

+4 −2
Original line number Diff line number Diff line
@@ -32,10 +32,12 @@ async function checkCommitMessages({ github, context, core }) { 


  if (

    baseBranchType.includes('development') &&

    headBranchType.includes('development')

    headBranchType.includes('development') &&

    pr.base.repo.id === pr.head.repo?.id

  ) {

    // This matches, for example, PRs from staging-next to master, or vice versa.

    // This matches, for example, PRs from NixOS:staging-next to NixOS:master, or vice versa.

    // Ignore them: we should only care about PRs introducing *new* commits.

    // We still want to run on PRs from, e.g., Someone:master to NixOS:master, though.

    core.info(

      'This PR is from one development branch to another. Skipping checks.',

    )