Commit 0996ac6b authored by Josef Kemetmüller's avatar Josef Kemetmüller
Browse files

nvtop: Make independent of Nvidia driver version 

For packages relying on Nvidia drivers we don't want to hard-code the
location of a particular driver version in the RPATH. Otherwise the
software might fail with errors such as:

> Impossible to initialize nvidia nvml : Driver/library version mismatch

To fix this the usual pattern in nixpkgs is to add `/run/opengl-driver/lib`
to the RPATH of these binaries.
This is the global location where Nvidia libraries are available on
NixOS and so this makes sure that the nvtop binary can be run with all
versions of the driver.

At build time however these libraries are not available at that
particular location. For precisely this use case, Nvidia ships stub
versions of the driver libraries with the cudatoolkit. So we just need
to point CMake to that directory.

Fixes: #98328
parent 799f149b

pkgs/tools/system/nvtop/default.nix

+10 −6
Original line number Diff line number Diff line 
{ stdenv, fetchFromGitHub, cmake, nvidia_x11, cudatoolkit, ncurses }:

{ stdenv, fetchFromGitHub, cmake, cudatoolkit, ncurses, addOpenGLRunpath }:



stdenv.mkDerivation rec {

  pname = "nvtop";
@@ -13,15 +13,19 @@ stdenv.mkDerivation rec { 


  cmakeFlags = [

    "-DNVML_INCLUDE_DIRS=${cudatoolkit}/include"

    "-DNVML_LIBRARIES=${nvidia_x11}/lib/libnvidia-ml.so"

    "-DNVML_LIBRARIES=${cudatoolkit}/targets/x86_64-linux/lib/stubs/libnvidia-ml.so"

    "-DCMAKE_BUILD_TYPE=Release"

  ];



  nativeBuildInputs = [ cmake ];

  buildInputs = [ ncurses nvidia_x11 cudatoolkit ];

  nativeBuildInputs = [ cmake addOpenGLRunpath ];

  buildInputs = [ ncurses cudatoolkit ];



  postFixup = ''

    addOpenGLRunpath $out/bin/nvtop

  '';



  meta = with stdenv.lib; {

    description = "A (h)top like like task monitor for NVIDIA GPUs";

    description = "A (h)top like task monitor for NVIDIA GPUs";

    homepage = "https://github.com/Syllo/nvtop";

    license = licenses.gpl3;

    platforms = platforms.linux;

pkgs/top-level/all-packages.nix

+1 −3
Original line number Diff line number Diff line
@@ -14607,9 +14607,7 @@ in 














  nvidia-optical-flow-sdk = callPackage ../development/libraries/nvidia-optical-flow-sdk { };



























  nvtop = callPackage ../tools/system/nvtop {













    nvidia_x11 = linuxPackages.nvidia_x11.override { libsOnly = true; };













  };













  nvtop = callPackage ../tools/system/nvtop { };





























  ocl-icd = callPackage ../development/libraries/ocl-icd { };