Unverified Commit 06f50f4a authored by Maximilian Bosch's avatar Maximilian Bosch
Browse files

nixos/networkd: warn about naively replacing IPForward 

See https://github.com/systemd/systemd/issues/33414.

The way this was phrased sounded like a dumb search/replace operation to
me. This resulted in random parts of my routing being broken (forward
from if X -> Y being fine, but the opposite direction being broken).

This change makes it explicit that it's a little more complicated and
you should really consult the docs before making that change.
parent 6306bb79

nixos/modules/system/boot/networkd.nix

+1 −1
Original line number Diff line number Diff line
@@ -716,7 +716,7 @@ let 
        (assertValueOneOf "EmitLLDP" (boolValues ++ ["nearest-bridge" "non-tpmr-bridge" "customer-bridge"]))

        (assertValueOneOf "UseDomains" (boolValues ++ ["route"]))

        (assertValueOneOf "DNSDefaultRoute" boolValues)

        (assertRemoved "IPForward" "IPv4Forwarding and IPv6Forwarding in systemd.network(5) and networkd.conf(5)")

        (assertRemoved "IPForward" "IPv4Forwarding and IPv6Forwarding in systemd.network(5) and networkd.conf(5). Please note that setting these options on multiple interfaces may lead to unintended results, see https://github.com/systemd/systemd/issues/33414 or the relevant sections in systemd.network(5).")

        (assertValueOneOf "IPv4Forwarding" boolValues)

        (assertValueOneOf "IPv6Forwarding" boolValues)

        (assertValueOneOf "IPMasquerade" (boolValues ++ ["ipv4" "ipv6" "both"]))