Commit 044abb14 authored by Guilhem Saurel's avatar Guilhem Saurel
Browse files

lib3mf: fix header install 

Somehow this was working before, but around 2025-10-23, something
changed on master, and nixpkgs-review would stop working on
https://github.com/NixOS/nixpkgs/pull/445078:

```
$ nix build -L github:NixOS/nixpkgs/pull/445078/head#lib3mf.dev
$ eza result-dev/include/
 lib3mf/
$ nix build -L github:NixOS/nixpkgs/pull/445078/merge#lib3mf.dev
$ eza result-dev/include/
"result-dev/include/": No such file or directory (os error 2)
```

The headers are now installed in the build tree:
```
-- Installing: /nix/store/i7qd0hcky65i557fqjl5qq3xrp30hwhz-lib3mf-2.4.1/lib/lib3mf.so.2
-- Installing: /nix/store/i7qd0hcky65i557fqjl5qq3xrp30hwhz-lib3mf-2.4.1/lib/lib3mf.so
-- Installing: /build/source/build/include/lib3mf/Bindings
-- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS
-- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS/lib3mf_nodeaddon.cc
-- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS/lib3mf_nodewrapper.cc
```

Maybe CMake 4.1.1 -> 4.1.2 changed something.
parent 974b7b39

pkgs/by-name/li/lib3mf/package.nix

+1 −1
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ stdenv.mkDerivation (finalAttrs: { 
  ];



  cmakeFlags = [

    "-DCMAKE_INSTALL_INCLUDEDIR=include/lib3mf"

    "-DCMAKE_INSTALL_INCLUDEDIR=${placeholder "dev"}/include/lib3mf"

    "-DUSE_INCLUDED_ZLIB=OFF"

    "-DUSE_INCLUDED_LIBZIP=OFF"

    "-DUSE_INCLUDED_GTEST=OFF"