Unverified Commit 02573873 authored by Diego Pontoriero's avatar Diego Pontoriero Committed by GitHub
Browse files

nodePackages.graphite-cli: fix zsh completion 

The yargs library auto-detects the shell from the environment to emit the appropriate completion script. Currently the override is emitting the bash completion script twice. Setting ZSH_NAME=zsh is a simple way to emit the zshell completion script.
parent d377d9bc

pkgs/development/node-packages/overrides.nix

+3 −1
Original line number Diff line number Diff line
@@ -188,10 +188,12 @@ final: prev: { 
  graphite-cli = prev."@withgraphite/graphite-cli".override {

    name = "graphite-cli";

    nativeBuildInputs = [ pkgs.installShellFiles ];

    # 'gt completion' auto-detects zshell from environment variables:

    # https://github.com/yargs/yargs/blob/2b6ba3139396b2e623aed404293f467f16590039/lib/completion.ts#L45

    postInstall = ''

      installShellCompletion --cmd gt \

        --bash <($out/bin/gt completion) \

        --zsh <($out/bin/gt completion)

        --zsh <(ZSH_NAME=zsh $out/bin/gt completion)

    '';

  };