Unverified Commit 0010ba25 authored by Wolfgang Walther's avatar Wolfgang Walther
Browse files

various: fix hostPlatform.canExecute buildPlatform 

It doesn't matter whether the hostPlatform could execute stuff from the
buildPlatform - we need it the other way around: Certain things during a
build process can only happen when, as part of the build, the
**buildPlatform** can execute the code it just created for the
**hostPlatform**.

Unless we are talking about compilation at run-time, as in the case of
PostgreSQL. Extend the comment there to make it clear that this is on
purpose. Another case that's OK is vlc, where luac can't cross-compile
at build time, thus the bytecode is actually build for the buildPlatform
and the sources must be interpreted at runtime instead.
parent 885c83f6

pkgs/by-name/li/libnvme/package.nix

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ 
  swig,

  systemd,

  # ImportError: cannot import name 'mlog' from 'mesonbuild'

  withDocs ? stdenv.hostPlatform.canExecute stdenv.buildPlatform,

  withDocs ? stdenv.buildPlatform.canExecute stdenv.hostPlatform,

}:



stdenv.mkDerivation (finalAttrs: {

pkgs/by-name/re/repgrep/package.nix

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ rustPlatform.buildRustPackage rec { 
      installManPage rgr.1

      popd

    ''

    + lib.optionalString (stdenv.hostPlatform.canExecute stdenv.buildPlatform) ''

    + lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) ''

      # As it can be seen here: https://github.com/acheronfail/repgrep/blob/0.15.0/.github/workflows/release.yml#L206, the completions are just the same as ripgrep

      installShellCompletion --cmd rgr \

        --bash <(${lib.getExe ripgrep} --generate complete-bash | sed 's/-c rg/-c rgr/') \

pkgs/by-name/vl/vlc/package.nix

+1 −1
Original line number Diff line number Diff line
@@ -251,7 +251,7 @@ stdenv.mkDerivation (finalAttrs: { 
          ${freefont_ttf}/share/fonts/truetype

    ''

    # Upstream luac can't cross compile, so we have to install the lua sources

    # instead of bytecode:

    # instead of bytecode, which was built for buildPlatform:

    # https://www.lua.org/wshop13/Jericke.pdf#page=39

    + lib.optionalString (!stdenv.hostPlatform.canExecute stdenv.buildPlatform) ''

      substituteInPlace share/Makefile.am \

pkgs/servers/sql/postgresql/generic.nix

+3 −0
Original line number Diff line number Diff line
@@ -407,6 +407,9 @@ let 
        # resulting LLVM IR isn't platform-independent this doesn't give you much.

        # In fact, I tried to test the result in a VM-test, but as soon as JIT was used to optimize

        # a query, postgres would coredump with `Illegal instruction`.

        #

        # Note: This is "host canExecute build" on purpose, since this is about the LLVM that is called

        # to do JIT at **runtime**.

        broken = jitSupport && !stdenv.hostPlatform.canExecute stdenv.buildPlatform;

      };

    });