Commit aa06c66a authored by gbalduzz's avatar gbalduzz
Browse files

default compute-G-correlation is false (MC weightn is usually a good measure).

parent 55bbb629

include/dca/phys/parameters/mci_parameters.hpp

+1 −1
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ private: 
  std::vector<int> measurements_;

  int measurements_final_iter_ = -1;

  int time_correlation_window_ = 0;

  bool compute_G_correlation_ = true;

  bool compute_G_correlation_ = false;

  int walkers_;

  int accumulators_;

  bool shared_walk_and_accumulation_thread_;

misc/wiki/Parameters.md

+1 −1
Original line number Diff line number Diff line
@@ -430,7 +430,7 @@ Determines the type of error computation that will be performed during the last 
 Maximum distance (in MC time) considered when computing the correlation between configurations.

 If 0, no auto-correlation is computed.

 

`"compute-G-correlation":` boolean (true)

`"compute-G-correlation":` boolean (false)

If `time-correlation-window` is larger than 0, G(r = 0, t = 0) is included in the observables

whose autocorrelation is computed. This measurements requires some device memory.

test/unit/phys/parameters/mci_parameters/input_read_all.json

+4 −0
Original line number Diff line number Diff line
@@ -7,6 +7,10 @@ 
        "error-computation-type" : "JACK_KNIFE",

        "store-configuration" : true,



        "time-correlation-window" : 100,

        "compute-G-correlation" : true,

        "stamping-period" : 100,



        "threaded-solver": {

            "walkers": 3,

            "accumulators": 5,

test/unit/phys/parameters/mci_parameters/mci_parameters_test.cpp

+6 −0
Original line number Diff line number Diff line
@@ -36,6 +36,9 @@ TEST(MciParametersTest, DefaultValues) { 
  EXPECT_EQ(false, pars.shared_walk_and_accumulation_thread());

  EXPECT_FALSE(pars.adjust_self_energy_for_double_counting());

  EXPECT_FALSE(pars.store_configuration());

  EXPECT_EQ(0, pars.get_time_correlation_window());

  EXPECT_EQ(false, pars.compute_G_correlation());

  EXPECT_EQ(0, pars.stamping_period());

}



TEST(MciParametersTest, ReadAll) {
@@ -57,6 +60,9 @@ TEST(MciParametersTest, ReadAll) { 
  EXPECT_EQ(5, pars.get_accumulators());

  EXPECT_EQ(true, pars.shared_walk_and_accumulation_thread());

  EXPECT_TRUE(pars.store_configuration());

  EXPECT_EQ(100, pars.get_time_correlation_window());

  EXPECT_EQ(true, pars.compute_G_correlation());

  EXPECT_EQ(100, pars.stamping_period());

}



TEST(MciParametersTest, ReadPositiveIntegerSeed) {