Unverified Commit fdd00785 authored by David López's avatar David López Committed by GitHub
Browse files

Merge pull request #14198 from mvdbeek/avoid_placeholders_in_selectors 

[22.05] Avoid placeholder value in selenium selectors
parents 35e2f759 96b9c2fa

client/src/components/History/Content/Dataset/DatasetDetails.vue

+2 −2
Original line number Diff line number Diff line 
<template>

    <DatasetProvider :id="dataset.id" v-slot="{ loading, result }" auto-refresh>

        <div v-if="!loading" class="dataset">

            <div class="p-2 details">

            <div class="p-2 details not-loading">

                <div class="summary">

                    <div v-if="stateText" class="mb-1">{{ stateText }}</div>

                    <div v-else-if="result.misc_blurb" class="blurb">
@@ -33,7 +33,7 @@ 
                having more standard 'placeholder' versions of pre-loaded

                components) )

            -->

            <div class="p-2 details">

            <div class="p-2 details loading">

                <div class="summary">

                    <div class="blurb">

                        <span class="value">? lines</span>

client/src/utils/navigation/navigation.yml

+5 −5
Original line number Diff line number Diff line
@@ -168,10 +168,10 @@ history_panel: 


      hid: '${_} .hid'

      name: '${_} .name'

      blurb: '${_} .blurb .value'

      dbkey: '${_} .dbkey .value'

      info: '${_} .info .value'

      peek: '${_} .dataset-peek'

      blurb: '${_} .not-loading .blurb .value'

      dbkey: '${_} .not-loading .dbkey .value'

      info: '${_} .not-loading .info .value'

      peek: '${_} .not-loading .dataset-peek'

      toolhelp_title: '${_} .toolhelp strong'



      # Title buttons...
@@ -682,7 +682,7 @@ invocations: 
    step_output_collection_element_identifier:

      type: xpath

      selector: '//span[@class="content-title name"][text()="${element_identifier}"]'

    step_output_collection_element_datatype: '.workflow-invocation-state-component .invocation-steps-details [data-step="${order_index}"] .invocation-step-output-collection-details .datatype .value'

    step_output_collection_element_datatype: '.workflow-invocation-state-component .invocation-steps-details [data-step="${order_index}"] .invocation-step-output-collection-details .not-loading .datatype .value'

    step_job_details: '.workflow-invocation-state-component .invocation-steps-details [data-step="${order_index}"] .invocation-step-job-details'

    step_job_table: '.workflow-invocation-state-component .invocation-steps-details [data-step="${order_index}"] .invocation-step-job-details table'

    step_job_table_rows: '.workflow-invocation-state-component .invocation-steps-details [data-step="${order_index}"] .invocation-step-job-details table tbody tr'