Unverified Commit fc1fc4bb authored by mvdbeek's avatar mvdbeek
Browse files

Fix visible handling for exisiting datasets on discovery

Fixes the flaky selenium upload tests and prevents fetch_data uploads
from reverting from hidden to visible on job finish.
parent 5fd1141c
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -100,7 +100,6 @@ class ModelPersistenceContext(metaclass=abc.ABCMeta):

        if primary_data is not None:
            primary_data.extension = ext
            primary_data.visible = visible
            primary_data.dbkey = dbkey
        else:
            if not library_folder:
@@ -798,12 +797,13 @@ def persist_hdas(elements, model_persistence_context, final_job_state="ok"):
                hashes = fields_match.hashes
                created_from_basename = fields_match.created_from_basename
                extra_files = fields_match.extra_files
                visible = fields_match.visible

                info, state = discovered_file.discovered_state(element, final_job_state)
                dataset = model_persistence_context.create_dataset(
                    ext=ext,
                    designation=designation,
                    visible=True,
                    visible=visible,
                    dbkey=dbkey,
                    name=name,
                    filename=discovered_file.path,