Add displayed_name to /api/roles endpoint

from typing import Optional

from galaxy.managers.context import ProvidesUserContext

from galaxy.managers.roles import RoleManager

from galaxy.model.db.role import get_private_role_user_emails_dict

from galaxy.schema.fields import (

    DecodedDatabaseIdField,

    Security,

from galaxy.webapps.galaxy.services.base import ServiceBase

def role_to_model(role):

def role_to_model(role, displayed_name: Optional[str] = None):

    item = role.to_dict(view="element")

    role_id = Security.security.encode_id(role.id)

    item["url"] = url_for("role", id=role_id)

    if displayed_name:

        item["displayed_name"] = displayed_name

    return RoleModelResponse(**item)

    def get_index(self, trans: ProvidesUserContext) -> RoleListResponse:

        roles = self.role_manager.list_displayable_roles(trans)

        return RoleListResponse(root=[role_to_model(r) for r in roles])

        private_role_emails = get_private_role_user_emails_dict(trans.sa_session)

        data = []

        for role in roles:

            displayed_name = private_role_emails.get(role.id, role.name)

            data.append(role_to_model(role, displayed_name))

        return RoleListResponse(root=data)

    def show(self, trans: ProvidesUserContext, id: DecodedDatabaseIdField) -> RoleModelResponse:

        role = self.role_manager.get(trans, id)