Unverified Commit ddc07c90 authored by John Chilton's avatar John Chilton Committed by GitHub
Browse files

Merge pull request #20412 from mvdbeek/fix_validators_from_expression_json

[24.2] Skip validation of expression.json input in workflow parameter validator
parents 323d47e8 a50f890b
Loading
Loading
Loading
Loading
+13 −1
Original line number Diff line number Diff line
@@ -1630,6 +1630,18 @@ class InputParameterModule(WorkflowModule):
        input_param = self.get_runtime_inputs(self)["input"]
        # TODO: raise DelayedWorkflowEvaluation if replacement not ready ? Need test
        try:
            if not isinstance(
                input_value,
                (
                    model.DatasetInstance,
                    model.HistoryDatasetCollectionAssociation,
                    model.DatasetCollection,
                    model.DatasetCollectionElement,
                ),
            ):
                # We could attempt to turn expression.json datasets back into validatable values,
                # but then we'd have to delay scheduling until they are ready. workflow parmater value validators are
                # likely most important for parent workflows, where they run on primitive values.
                input_param.validate(input_value, trans)
        except ValueError as e:
            raise FailWorkflowEvaluation(