Unverified Commit b2d52ace authored by mvdbeek's avatar mvdbeek
Browse files

Fix null inputs in database operation tools 

And fix test that was supposed to cover this.
Fixes https://github.com/galaxyproject/galaxy/issues/18384
parent 96c9be32

lib/galaxy/tools/__init__.py

+3 −1
Original line number Diff line number Diff line
@@ -3235,6 +3235,8 @@ class DatabaseOperationTool(Tool): 
                    )



        for input_dataset in input_datasets.values():

            if input_dataset:

                # None is a possible input for optional inputs

                check_dataset_state(input_dataset.state)



        for input_dataset_collection_pairs in input_dataset_collections.values():

lib/galaxy/tools/build_list_1.2.0.xml

+2 −1
Original line number Diff line number Diff line
@@ -77,6 +77,7 @@ This tool will create a new collection from your history datasets but your quota 
    </test>

    <test>

      <repeat name="datasets">

        <param name="input" value_json="null"/>

      </repeat>

      <output_collection name="output" type="list" count="0">

      </output_collection>