Unverified Commit b1084df4 authored by mvdbeek's avatar mvdbeek
Browse files

Disable text input for unselected inputs 

This means they won't be included in the submitted form.
Since we just pick the index of a selected dataset name in
`extract_steps` this would lead to the wrong inptu dataset label in the
workflow editor. Fixes the first issue in https://github.com/galaxyproject/galaxy/issues/12590
parent 601cd783

templates/webapps/galaxy/workflow/build_from_current_history.mako

+4 −1
Original line number Diff line number Diff line
@@ -33,10 +33,12 @@ 
    $(function() {

        $("#checkall").click( function() {

            $("input[type=checkbox]").attr( 'checked', true );

            $(".as-named-input").prop( 'disabled', false );

            return false;

        }).show();

        $("#uncheckall").click( function() {

            $("input[type=checkbox]").attr( 'checked', false );

            $(".as-named-input").prop( 'disabled', true );

            return false;

        }).show();

    });
@@ -62,7 +64,8 @@ 
                    </div>

                    %if disabled:

                        <input type="checkbox" id="as-input-${ encoded_id }" class="as-input"

                               name="${data.history_content_type}_ids" value="${data.hid}" checked="true" />

                               name="${data.history_content_type}_ids" value="${data.hid}" checked="true"

                               onclick="document.getElementById('as-named-input-${ encoded_id }').disabled = !document.getElementById('as-input-${ encoded_id }').checked" />

                        <label for="as-input-${ encoded_id }" >${_('Treat as input dataset')}</label>

                        <input type="text" id="as-named-input-${ encoded_id }" class="as-named-input"

                               name="${data.history_content_type}_names" value="${data.display_name() | h}" />