Commit 9feebb88 authored by davelopez's avatar davelopez
Browse files

Fix tours selectors 

The buttons are now considered links so better use the class to select them since it will be less prone to change than the title.
parent 1638dc02

client/src/components/History/Content/ContentOptions.vue

+5 −5
Original line number Diff line number Diff line
@@ -4,7 +4,7 @@ 
            v-if="isDataset"

            :disabled="displayDisabled"

            :title="displayButtonTitle"

            class="px-1"

            class="display-btn px-1"

            size="sm"

            variant="link"

            :href="itemUrls.display"
@@ -15,7 +15,7 @@ 
            v-if="isHistoryItem"

            :disabled="editDisabled"

            :title="editButtonTitle"

            class="px-1"

            class="edit-btn px-1"

            size="sm"

            variant="link"

            :href="itemUrls.edit"
@@ -24,7 +24,7 @@ 
        </b-button>

        <b-button

            v-if="isHistoryItem && !isDeleted"

            class="px-1"

            class="delete-btn px-1"

            title="Delete"

            size="sm"

            variant="link"
@@ -33,7 +33,7 @@ 
        </b-button>

        <b-button

            v-if="isHistoryItem && isDeleted"

            class="px-1"

            class="undelete-btn px-1"

            title="Undelete"

            size="sm"

            variant="link"
@@ -42,7 +42,7 @@ 
        </b-button>

        <b-button

            v-if="isHistoryItem && !isVisible"

            class="px-1"

            class="unhide-btn px-1"

            title="Unhide"

            size="sm"

            variant="link"

client/src/utils/navigation/navigation.yml

+2 −3
Original line number Diff line number Diff line
@@ -287,9 +287,8 @@ history_panel: 
    options_use_legacy_history: 'a[data-description="switch to legacy history view"]'



    collection_menu_button: '.collection-menu'

    collection_menu_edit_attributes:

      type: xpath

      selector: '//button[@title="Edit attributes"]'

    collection_menu_edit_attributes: '.edit-btn'



    new_history_button: '.history-new-button'

    multi_view_button: '.history-view-multi-button'

    histories_operation_menu: '[data-description="history options"]'

config/plugins/tours/core.galaxy_ui.yaml

+6 −6
Original line number Diff line number Diff line
@@ -92,11 +92,11 @@ steps: 
              grey this means you are queued and need to wait until your tool can be started. If your dataset turns into red, an error has occurred. Please report the bug to the Galaxy team with the bug report button."



    - title: "View dataset"

      element: "#current-history-panel div.content-item button[title='Display']"

      element: "#current-history-panel div.content-item .display-btn"

      intro: "View your dataset by clicking the eye button."



    - title: "Rename dataset"

      element: "#current-history-panel div.content-item button[title='Edit attributes']"

      element: "#current-history-panel div.content-item .edit-btn"

      intro: "Rename your dataset by clicking the pencil button."



    - title: "Dataset information"
@@ -105,16 +105,16 @@ steps: 
      postclick: true



    - title: "Remove dataset"

      element: "#current-history-panel div.content-item button[title='Delete']"

      element: "#current-history-panel div.content-item .delete-btn"

      intro: "Delete your dataset by clicking the trash-button."



    - title: "Dataset information"

      element: "#current-history-panel div.content-item button[title='Dataset Details']"

      element: "#current-history-panel div.content-item .params-btn"

      intro: "Clicking on your dataset provides you with more information regarding your dataset (e.g. filetype or size)."

      preclick: true



    - title: "Re-run tool"

      element: "#current-history-panel div.content-item button[title='Run Job Again']"

      element: "#current-history-panel div.content-item .rerun-btn"

      intro: "By clicking the reload button, you can re-run your tool again (e.g. with different parameters or on another dataset)."



    - title: "Panel collapse"

config/plugins/tours/core.history.yaml

+6 −7
Original line number Diff line number Diff line
@@ -47,26 +47,26 @@ steps: 
      element: "#current-history-panel div.content-item span.datatype"

      intro: "Galaxy has assigned a datatype to your dataset during upload, which you can see here."



    - element: "#current-history-panel div.content-item button[title='Download']"

    - element: "#current-history-panel div.content-item .download-btn"

      title: "Download your dataset"

      intro: "You can download every dataset by using the floppy disc symbol."



    - element: "#current-history-panel div.content-item button[title='Dataset Details']"

    - element: "#current-history-panel div.content-item .params-btn"

      title: "Even more information"

      intro: "Get an overview of all metadata associated with your dataset by using the Information symbol."

      preclick: true



    - element: "#current-history-panel div.content-item button[title='Display']"

    - element: "#current-history-panel div.content-item .display-btn"

      title: "Inspect your data"

      intro: "The eye symbol can be used to look at your data."

      preclick: true



    - element: "#current-history-panel div.content-item button[title='Edit attributes']"

    - element: "#current-history-panel div.content-item .edit-btn"

      title: "Edit metadata"

      intro: "With the pencil button you can edit metadata attributes of your dataset, like the associated filetype or the dataset name."

      preclick: true



    - element: "#current-history-panel div.content-item button[title='Delete']"

    - element: "#current-history-panel div.content-item .delete-btn"

      title: "Remove datasets"

      intro: "You can remove a dataset from the history with the trash can symbol."

      postclick: true
@@ -76,7 +76,7 @@ steps: 
      intro: "By default your history will hide all deleted datasets from you. You can visualize them by filtering."

      textinsert: "deleted:true"



    - element: "#current-history-panel div.content-item button[title='Undelete']"

    - element: "#current-history-panel div.content-item .undelete-btn"

      title: "Undeleting a dataset"

      intro: |

            Galaxy datasets are only marked as deleted and can be recovered by clicking this link.
@@ -95,4 +95,3 @@ steps: 


    - title: "Enjoy your Galaxy Histories"

      intro: "Thanks for taking this tour! Happy research with Galaxy!"

config/plugins/tours/core.windows.yaml

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ steps: 
    - element: "#right"

      intro: "This is your history. It contains all datasets you are currently working with including our uploaded table."



    - element: "#current-history-panel div.content-item button[title='Display']"

    - element: "#current-history-panel div.content-item .display-btn"

      intro: "Clicking the eye-icon usually displays a dataset in the center panel."

      postclick: true