Commit 9b0bc2bf authored by Dannon Baker's avatar Dannon Baker
Browse files

Cleanup, formatting, comments.

parent 67d86e76
Loading
Loading
Loading
Loading
+5 −4
Original line number Diff line number Diff line
@@ -89,7 +89,6 @@ import ManageObjectStoreIndex from "@/components/ObjectStore/Instances/ManageInd
import UpgradeObjectStoreInstance from "@/components/ObjectStore/Instances/UpgradeInstance.vue";
import CreateUserObjectStore from "@/components/ObjectStore/Templates/CreateUserObjectStore.vue";
import Sharing from "@/components/Sharing/SharingPage.vue";
// import CustomToolEditor from "@/components/Tool/CustomToolEditor.vue";
import HistoryStorageOverview from "@/components/User/DiskUsage/Visualizations/HistoryStorageOverview.vue";
import UserDatasetPermissions from "@/components/User/UserDatasetPermissions.vue";
import WorkflowPublished from "@/components/Workflow/Published/WorkflowPublished.vue";
@@ -100,16 +99,18 @@ import WorkflowInvocationState from "@/components/WorkflowInvocationState/Workfl
Vue.use(VueRouter);

// Async component for CustomToolEditor to reduce bundle size
// NOTE: We use the full async component factory pattern instead of simple dynamic imports
// (i.e., `() => import("@/components/Tool/CustomToolEditor.vue")`) due to what I think are router limitations.  Revisit with vr-4
const CustomToolEditor = () => ({
    component: import("@/components/Tool/CustomToolEditor.vue"),
    loading: {
        template: '<div class="text-center"><i class="fa fa-spinner fa-spin"></i> Loading Tool Editor...</div>'
        template: '<div class="text-center"><i class="fa fa-spinner fa-spin"></i> Loading Tool Editor...</div>',
    },
    error: {
        template: '<div class="alert alert-danger">Failed to load Tool Editor</div>'
        template: '<div class="alert alert-danger">Failed to load Tool Editor</div>',
    },
    delay: 200,
    timeout: 10000
    timeout: 10000,
});

// patches $router.push() to trigger an event and hide duplication warnings
+2 −2
Original line number Diff line number Diff line
@@ -105,8 +105,8 @@ module.exports = (env = {}, argv = {}) => {
                    },
                    monaco: {
                        test: /[\\/]node_modules[\\/]monaco-editor[\\/]/,
                        name: 'monaco',
                        chunks: 'all',
                        name: "monaco",
                        chunks: "all",
                        enforce: true,
                    },
                },