Unverified Commit 8c3d967a authored by Ahmed Awan's avatar Ahmed Awan Committed by mvdbeek
Browse files

fix published history collections are empty on expand 

Only check ownership in `__get_history_collection_instance` if:
`collection_instance.history.published` = False
parent c94ec0d4

lib/galaxy/managers/collections.py

+1 −1
Original line number Diff line number Diff line
@@ -807,7 +807,7 @@ class DatasetCollectionManager: 
            raise RequestParameterInvalidException("History dataset collection association not found")

        # TODO: that sure looks like a bug, we can't check ownership using the history of the object we're checking ownership for ...

        history = getattr(trans, "history", collection_instance.history)

        if check_ownership:

        if check_ownership and collection_instance.history.published is False:

            self.history_manager.error_unless_owner(collection_instance.history, trans.user, current_history=history)

        if check_accessible:

            self.history_manager.error_unless_accessible(