Unverified Commit 7b316215 authored by Nicola Soranzo's avatar Nicola Soranzo Committed by GitHub
Browse files

Merge pull request #7504 from mvdbeek/logging_fix 

[18.09] Fix warning message formatting in sharing controller
parents 8e125b76 98a189ce

lib/galaxy/web/base/controller.py

+2 −2
Original line number Diff line number Diff line
@@ -1459,10 +1459,10 @@ class SharableMixin(object): 
                    try:

                        trans.app.security_agent.make_dataset_public(hda.dataset)

                    except Exception:

                        log.warning("Unable to make dataset with id: %s public.").format(dataset.id)

                        log.warning("Unable to make dataset with id: %s public", dataset.id)

                        skipped = True

                else:

                    log.warning("User without permissions tried to make dataset with id: %s public.").format(dataset.id)

                    log.warning("User without permissions tried to make dataset with id: %s public", dataset.id)

                    skipped = True

        return item, skipped