Unverified Commit 5e6afdd5 authored Jun 14, 2024 by mvdbeek

Fix ``get_accessible_job`` if called without session

Fixes https://github.com/galaxyproject/galaxy/issues/18399:

```
ExceptionGroup: unhandled errors in a TaskGroup
  File "starlette/_utils.py", line 87, in collapse_excgroups
    yield
  File "starlette/middleware/base.py", line 190, in __call__
    async with anyio.create_task_group() as task_group:
  File "anyio/_backends/_asyncio.py", line 678, in __aexit__
    raise BaseExceptionGroup(

AttributeError: 'NoneType' object has no attribute 'id'
(25 additional frame(s) were not displayed)
...
  File "galaxy/webapps/galaxy/fast_app.py", line 109, in add_x_frame_options
    response = await call_next(request)
  File "galaxy/webapps/galaxy/api/jobs.py", line 261, in common_problems
    job = self.service.get_job(trans=trans, job_id=job_id)
  File "galaxy/webapps/galaxy/services/jobs.py", line 121, in get_job
    return self.job_manager.get_accessible_job(trans, decoded_job_id=job_id)
  File "galaxy/managers/jobs.py", line 271, in get_accessible_job
    else (job.session_id == trans.get_galaxy_session().id)
```

parent d0ebd5a4

lib/galaxy/managers/jobs.py

+6 −6

Original line number	Diff line number	Diff line
		@@ -260,15 +260,15 @@ class JobManager:
		)
		return self.job_lock()

		def get_accessible_job(self, trans, decoded_job_id) -> Job:
		def get_accessible_job(self, trans: ProvidesUserContext, decoded_job_id) -> Job:
		job = trans.sa_session.get(Job, decoded_job_id)
		if job is None:
		raise ObjectNotFound()
		belongs_to_user = (
		(job.user_id == trans.user.id)
		if job.user_id and trans.user
		else (job.session_id == trans.get_galaxy_session().id)
		)
		belongs_to_user = False
		if trans.user:
		belongs_to_user = job.user_id == trans.user.id
		elif trans.galaxy_session:
		belongs_to_user = job.session_id == trans.galaxy_session.id
		if not trans.user_is_admin and not belongs_to_user:
		# Check access granted via output datasets.
		if not job.output_datasets: