Unverified Commit 5c43d003 authored by Marius van den Beek's avatar Marius van den Beek Committed by GitHub
Browse files

Merge pull request #18569 from mvdbeek/ldda_not_found 

[24.1] Raise appropriate exception if ldda not found
parents cbbb5ef4 46aa4c02

lib/galaxy/webapps/galaxy/services/tools.py

+2 −1
Original line number Diff line number Diff line
@@ -281,7 +281,8 @@ class ToolsService(ServiceBase): 
    def _patch_library_dataset(self, trans: ProvidesHistoryContext, v, target_history):

        if isinstance(v, dict) and "id" in v and v.get("src") == "ldda":

            ldda = trans.sa_session.get(LibraryDatasetDatasetAssociation, self.decode_id(v["id"]))

            assert ldda

            if not ldda:

                raise exceptions.ObjectNotFound("Could not find library dataset dataset association.")

            if trans.user_is_admin or trans.app.security_agent.can_access_dataset(

                trans.get_current_user_roles(), ldda.dataset

            ):