Unverified Commit 5addd009 authored by Marius van den Beek's avatar Marius van den Beek Committed by GitHub
Browse files

Merge pull request #18014 from mvdbeek/debug_and_fix_hidless_hdas 

[24.0] Don't commit without having set a hid
parents 066dbba7 37bc4540

lib/galaxy/tools/actions/upload_common.py

+0 −2
Original line number Diff line number Diff line
@@ -140,8 +140,6 @@ def __new_history_upload(trans, uploaded_dataset, history=None, state=None): 
        hda.state = state

    else:

        hda.state = hda.states.QUEUED

    with transaction(trans.sa_session):

        trans.sa_session.commit()

    history.add_dataset(hda, genome_build=uploaded_dataset.dbkey, quota=False)

    permissions = trans.app.security_agent.history_get_default_permissions(history)

    trans.app.security_agent.set_all_dataset_permissions(hda.dataset, permissions, new=True, flush=False)