Commit 3b4ffd5d authored by John Chilton's avatar John Chilton
Browse files

Fix recording transform action name. 

The upload option is space_to_tab, but we've always recorded in the source transform json blob as spaces_to_tabs. I guess the past tense version - it sort of makes sense but anyway we don't want any of these inconsistent values in the database.
parent d0fb7a20

lib/galaxy/model/dereference.py

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ def dereference_to_model(sa_session, user, history, data_request_uri: DataReques 
    hda.dataset.sources = [dataset_source]

    transform: List[TransformAction] = []

    if data_request_uri.space_to_tab:

        transform.append({"action": "space_to_tab"})

        transform.append({"action": "spaces_to_tabs"})

    elif data_request_uri.to_posix_lines:

        transform.append({"action": "to_posix_lines"})

    if len(transform) > 0:

test/unit/data/test_dereference.py

+1 −1
Original line number Diff line number Diff line
@@ -54,4 +54,4 @@ def test_dereference_to_posix(): 
    hda = dereference_to_model(sa_session, user, history, uri_request)

    assert hda.name == "foobar.txt"

    assert hda.dataset.sources[0].source_uri == TEST_BASE64_URI

    assert hda.dataset.sources[0].transform[0]["action"] == "space_to_tab"
 
    assert hda.dataset.sources[0].transform[0]["action"] == "spaces_to_tabs"