Unverified Commit 38859d9d authored by mvdbeek's avatar mvdbeek
Browse files

Simplify and fix `useDatatypesMapper` 

The problem was that we'd immediately return if `createMapper` had
previously been called in another calling stack. I think we don't need
to do any error handling here, and the loading state can simply be
`datatypesMapperStore.loading`.

Fixes https://github.com/galaxyproject/galaxy/issues/18549
parent dc0ffcda

client/src/composables/datatypesMapper.ts

+5 −13
Original line number Diff line number Diff line
@@ -11,20 +11,12 @@ export function useDatatypesMapper() { 
    const datatypes: Ref<string[]> = ref([]);



    async function getDatatypesMapper() {

        try {

        await datatypesMapperStore.createMapper();

        datatypesMapperLoading.value = datatypesMapperStore.loading;

        datatypesMapper.value = datatypesMapperStore.datatypesMapper;

        if (datatypesMapperStore.datatypesMapper) {

            datatypes.value = datatypesMapperStore.datatypesMapper.datatypes;

        }

        } catch (e) {

            console.error("unable to create datatypes mapper\n", e);

        } finally {

            datatypesMapperLoading.value = false;

        }

        if (!datatypesMapperStore.datatypesMapper) {

            throw Error("Error creating datatypesMapper");

        }

    }



    getDatatypesMapper();