Unverified Commit 2311374c authored by Marius van den Beek's avatar Marius van den Beek Committed by GitHub
Browse files

Merge pull request #19079 from ahmedhamidawan/fetch_invocation_id_once_job_info 

[24.0] Fetch invocation id only once on the job info page
parents 19811a66 2cae82cf

client/src/components/JobInformation/JobInformation.vue

+16 −12
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ import { JobDetailsProvider } from "components/providers/JobProvider"; 
import UtcDate from "components/UtcDate";

import { formatDuration, intervalToDuration } from "date-fns";

import JOB_STATES_MODEL from "utils/job-states-model";

import { computed, ref } from "vue";

import { computed, ref, watch } from "vue";



import { invocationForJob } from "@/api/invocations";
@@ -13,7 +13,7 @@ import DecodedId from "../DecodedId.vue"; 
import CodeRow from "./CodeRow.vue";



const job = ref(null);

const invocationId = ref(null);

const invocationId = ref(undefined);



const props = defineProps({

    job_id: {
@@ -41,9 +41,6 @@ const metadataDetail = ref({ 


function updateJob(newJob) {

    job.value = newJob;

    if (newJob) {

        fetchInvocation(newJob.id);

    }

}



function filterMetadata(jobMessages) {
@@ -57,14 +54,21 @@ function filterMetadata(jobMessages) { 
    });

}



async function fetchInvocation(jobId) {

    if (jobId) {

        const invocation = await invocationForJob({ jobId: jobId });

// Fetches the invocation for the given job id to get the associated invocation id

watch(

    () => props.job_id,

    async (newId, oldId) => {

        if (newId && (invocationId.value === undefined || newId !== oldId)) {

            const invocation = await invocationForJob({ jobId: newId });

            if (invocation) {

                invocationId.value = invocation.id;

            } else {

                invocationId.value = null;

            }

        }

}

    },

    { immediate: true }

);

</script>



<template>