No reason to change the name of the property. Would be far more convient for existing clients if the name of this property remained the same.

LoadInstrument algorithm now uses OptionalBool. MandatoryValidator used and tests for that class have been fixed.

Refs #10557

Removed testExecGEM and testExecHRP. These were added at
early days of loadinstrument adding some of the first instruments
to mantid.

More recently a systemtest has been added that test
that all IDFs loads, hence the tests these performed
are now covered elsewhere

by heavily cut down hrpd instrument used for unit testing

and added unit test to test ok

It didn't account for parameterized instruments and was only
being used in a single test. Instead, getMonitors() followed by
getDetector() can be used.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

This one tests an IDF file not in the instrument folder with something extra added to its name uses the default parameter file in the instrument folder, because no parameter file has this extra part in its name.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

This test loads an IDF not in the instrument folder and checks that it uses a parameter file that is in the instrument folder.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

This reverts commit 0e379fa5.

This reverts commit 2e3e5c70.

This reverts commit 3ab9b121.

...directly, rather than a filename. This will be used by the SNS
live data listener.

by using the ADS::retrieveWS<Type>() method.

Allow for 'neutronic' detectors to have a different shape to their 'physical' counterpart. Re #1944.

Continue obsession with const: ExperimentInfo(MatrixWorkspace)::getInstrument now returns a const instrument. Re #1944.

Refs #3669: Refactored LoadInstrument by moving the parsing code to Geometry/InstrumentDefinitionParser. This allowed ExperimentInfo to use it to load the instrument directly.

Refs #3669: instrument XML contents are saved in NXS processed file. Much more painful then it needed to be.

Add pointer to physical instrument as a member (not used in vast majority of cases) of Instrument. Show this 'physical instrument' in the instrument view, if it exists. Re #1944.
P.S. This again lead to a const change which accounts for most of the changes.

Add ability for LoadInstrument to produce 2 instruments - one containing physical and the other 'neutronic' positions. Re #1944.