re: #32498

Removes instances of std::move where:
- We have a constant argument
- For trivial types
- For cr-types

Replaces const refs with std::move, so that the compiler can choose
between copy elision, refs or a cheap move

It connects the FunctionTreeView to the data table, and same with the check box above the FunctionTreeView. The following is now possible:

    Selecting individual or multiple datasets, and then add or remove functions to the FunctionTreeView for only these datasets by unticking the tick box.
    Add or remove functions to all datasets by ticking the checkbox.
    Selecting between datasets will display the functions related to that dataset.
    Switching between Sequential and Simultaneous fitting will hide/show the global parameter column and multi domain index

It is also now possible to do the following:

    Editing parameter and attribute values
    Local and global ties
    constraints
    global parameters

Cleaner solution

Clean up code a bit

Correct comment

Clang format

There was a problem with a for range loop and read access violation exceptions. Changed the loop to be more explicitly controlled

This commit adds unit test to the FunctionModel and FunctionMultiDomain presenter to cover the new attribute getters/setters.

This commit the model to be updated when individual attributes are changed in the view. Previously, any attribute being changed in the view would cause the full function be replaced and reconstructed. This is sometimes necessary when one of the attributes modifies the full function, e.g the order of polynomial - however most the time it is unnecessary. To avoid this a check has been included, which ensures the function is only reconstructed when it needs to be.

This commit ensures the correct value of the attribute (as taken from the model) is shown in the IFunctionView. This issue is prevalent for Q dependent functions, with the IFunctionView typically showing the incorrect value. In order to remedy this issue, methods to set attributes in the view have been added.

Given the new changes, both functions were broken. This commit fixes them by implementing attributeName method within tabular functions and modifying how the attribute X & Y are created.

Giovanni Di Siena authored Mar 31, 2020 and Gigg, Martyn Anthony committed Apr 07, 2020

In places other substitutions have been made, e.g
Clang does not yet specialize std::shared_ptr for T[]. Vector
has been used instead. The operator[] methods were incorrectly
marked const but returning a non-const reference - this has been fixed.
Refs #25842

Runs clang-tidy pass by ref across the codebase to fix-up various
warnings we are seeing in cppcheck

Also updated class_maker.py

This allows constraints to be empty so that if one is removed or if only one constraints is required it handles it correctly

The fitting tab was keeping a reference to two function browsers, which had to kept up-to-date with each-other. This issue has been addressed by introducing a single function browser.

The constraints box would accept any string, which would cause Mantid to crash. This has been fixed by ensuring that only doubles can be used as constraints. This commit implements this change.

When an attribute was changed in the fitting view all the previous functions were discarded. Fixed by modifying the emit signal to return the complete function.

Re #26144