This project is mirrored from https://github.com/mantidproject/mantid.git.
Pull mirroring updated .
- 30 Sep, 2020 1 commit
-
-
Danny Hindson authored
Based on review comments, revert the isHistogramData method to its original form without any parameters to avoid encouraging creation of matrix workspaces containing histograms with mix of xModes Create private function instead that allows a specific histogram to be checked
-
- 29 Sep, 2020 3 commits
-
-
Danny Hindson authored
-
Danny Hindson authored
-
Danny Hindson authored
The unit test suite MonteCarloAbsorptionTest has occasionally been failing with an access violation on Jenkins. I've been able to track this down to the test Lambda_StepSize_Two_Linear_Interpolation which was failing I can reproduce this locally by modifying the test to repeat 1000 times and it eventually fails. Although the access violation occurs in a couple of different places: a) the y() or e() vector in the 0th histogram is sometimes empty once the MonteCarloAbsorption algorithm completes which causes some of the test asserts to fall over because they assume y(0).front() or e(0).front b) sometimes the code in MonteCarloAbsorption itself has an access violation when yIndexOfX returns an index out of range of the histogram Both problems happen in the multi-threaded code in MonteCarloAbsorption and it seems to be the interaction between the call to MatrixWorkspace::yIndexOfX and the code that updates a histogram with interpolated results via MatrixWorkspace::setHistogram. Something in these two functions isn't threadsafe I found that yIndexOfX calls IsHistogramData() which checks the 0th histogram in the workspcae even if the MonteCarloAbsorption code is processing the 1st, 2nd etc workspace I think if the 0th histogram is in the process of being updated by another thread then yIndexOfX can fail or else the setHistogram call fails. I have done two changes: - only call yIndexOfX once (there was a redundant 2nd call) - I have modified yIndexOfX so it takes an additional histogram index parameter. This allows me to keep each MonteCarloAbsorption thread interacting with a single histogram only. I have defaulted the new parameter to zero so other code behaves as before
-
- 28 Sep, 2020 14 commits
-
-
Whitfield, Ross authored
Adding sphere integration tests
-
mantid-builder authored
-
Gagik Vardanyan authored
Fix key/completer handling in AddFunctionDialog
-
Gigg, Martyn Anthony authored
Fix Muon Analysis fit browser crash
-
Gigg, Martyn Anthony authored
Fix Windows package OpenGL issue over remote connection
-
Gigg, Martyn Anthony authored
Merge pull request #29628 from mantidproject/0_FixAnIssueWithRecentlyClosedScriptsThrowingErrorsWithGarbageData Recently Closed Scripts: TypeError handling where garbage data is gound
-
Stephen authored
Also in this commit plot guess is turned off by default when loading new data.
-
Tom Clayton authored
-
Kendrick, Coleman authored
-
Samuel Jones authored
-
Martyn Gigg authored
Added a view test to catch this behaviour Refs #29620
-
Martyn Gigg authored
-
Martyn Gigg authored
-
Martyn Gigg authored
Adds a test of the view using the QtTest framework Refs #29620
-
- 25 Sep, 2020 18 commits
-
-
Hahn, Steven authored
Unsupported instruments in DrILL
-
Guillaume Communie authored
Adds a check on the selected algorithm when opening the settings dialog. This avoids a crash if an unsupported instruments has been selected.
-
Guillaume Communie authored
Log an error if the user changes the facilty and DrILL is shown.
-
Guillaume Communie authored
The connection to the instrument selector widget is removed when the DrILL interface is closed. That avoids error messages coming from the interface when it is not
-
Kendrick, Coleman authored
-
Kendrick, Coleman authored
-
Kendrick, Coleman authored
-
Kendrick, Coleman authored
-
Martyn Gigg authored
-
Guillaume Communie authored
Removes the filering of instruments in the instrument selector widget of DrILL. This avoids a wrong instrument selection in DrILL if the user selected an unsupported instrument in workbench global settings.
-
Peterson, Peter authored
-
Whitfield, Ross authored
Geometry code cleanup
-
Zhang, Chen authored
-
DavidFair authored
Add separate page for Sliceviewer release notes
-
DavidFair authored
Format release notes for 5.1.0 Diffraction, Muons, LSS and Spec
-
Harrietbrown authored
Co-authored-by:
DanielMurphy22 <daniel.murphy@stfc.ac.uk>
-
Gigg, Martyn Anthony authored
Refs #29325. Enable workbench to have plot menu for MDHistoWorkspace.
-
Martyn Gigg authored
Co-authored-by:
DanielMurphy22 <daniel.murphy@stfc.ac.uk>
-
- 24 Sep, 2020 4 commits
-
-
Zhou, Wenduo authored
-
Zhou, Wenduo authored
-
Zhou, Wenduo authored
-
Zhou, Wenduo authored
Merge branch '29325_workbench_plot_md' of github.com:mantidproject/mantid into 29325_workbench_plot_md
-