GitLab

This includes commented out suppression, and obselete ones

Adds a cache dir, to avoid rebuilding the entire project each time. This
should save anywhere from 25-55 minutes per build (depending on which
node this hits).

Creates a dedicated cppcheck build directory for us to add the various
things, rather than cluttering up the users build dir.

Adds quotes to protect arguments, as we weren't doing this everywhere
previously

Boost.Python requires an accessible destructor for the wrapped
type so for singletons we are forced to use a const pointer
to a const object

--keep-going isn't available until sphinx 2.0
-W turns warnings into errors which should help jenkins figure out that
the build finished with warnings

Bumps cppcheck warning count up by 3. Cppcheck and clang-tidy disagree
on const ref and std::move.

Clang-tidy states that const ref makes the lifetime non-obvious, and
someone who want's to transfer ownership can use std::move

Cppcheck states that we should take a const ref because copy is
expensive (but doesn't not factor in std::move)

On balance, I'll favour clang-tidy because move is a thing and it
clarifies lifetime especially with shared_ptr. Since these warnings are
in a mess of 1700+ I can't see where the suppression goes, so lets leave
it for the future

--keep-going isn't available until sphinx 2.0
-W turns warnings into errors which should help jenkins figure out that
the build finished with warnings

This was incorrectly printing the expected counts, not the actual which
is misleading

Following various fixes from cppcheck

This prevent regressions from fixes previously in-flight

Removes instances of std::move where:
- We have a constant argument
- For trivial types
- For cr-types

Extracts the clang tidy block and does some tidying to simplify the
logic around it.

Add a clang-tidy file to handle all of our suppressed and active
warnings

Without it we cannot build with v5 of the sip builder tool

To keep things syncronized with the flags cmake gives the compiler, just
use the version set in cmake in the second place.

To keep things syncronized with the flags cmake gives the compiler, just
use the version set in cmake in the second place.

This bumps the warning count after upgrading to cppcheck 2.5 to the
current value, 1203

Bumps MSVC to use Sphinx 1.8.5 (matching Ubuntu 18.04). This allows us
to build dev-docs with warnings enabled on both platforms.

RHEL is the odd one out now, but as we have (comparitvely) few
developers on RHEL and this only affects dev docs we can cross that
bridge when Conda is complete

Bumps MSVC to use Sphinx 1.8.5 (matching Ubuntu 18.04). This allows us
to build dev-docs with warnings enabled on both platforms.

RHEL is the odd one out now, but as we have (comparitvely) few
developers on RHEL and this only affects dev docs we can cross that
bridge when Conda is complete

We are doing more and more dev-docs builds so enable them by default.
Additionally rely on -f to handle if the files / dirs are present or not
instead of checking

Since Workbench (Qt5) completely superseeds this, we can remove all
references to 4 as it's effectively dead code

Danny Hindson authored Aug 06, 2021 and Peterson, Peter committed Aug 06, 2021

Fix grep command that counts cppcheck errors
In order to trigger the job on Jenkins for this PR I have also
modified a couple of C++ files - specifically I have resolved a
cppcheck warning on method parameter in one of my algorithms
(CalculateMultipleScattering)

Fix grep command that counts cppcheck errors
In order to trigger the job on Jenkins for this PR I have also
modified a couple of C++ files - specifically I have resolved a
cppcheck warning on method parameter in one of my algorithms
(CalculateMultipleScattering)