This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. 22 Sep, 2021 2 commits
    • David Fairbrother's avatar
      Fix missing assignment op / copy ctor · 4f1fa389
      David Fairbrother authored
      Fixes instances with missing assignment operator or copy constructor.
      These are dangerous cases with dynamic memory as it's not obvious what
      will happen, but the compiler will try anyway.
      
      In many cases we can simply switch to unique_ptr or disable the copy
      when it makes sense. But one or two cases required additional thought.
      
      This fixes several memory leaks or sources of corruption if the fields
      fall out of sync
      4f1fa389
    • David Fairbrother's avatar
      Remove unmatched suppressions · c1f7406d
      David Fairbrother authored
      These are various places where cppcheck now understands c++-17, or we
      have improve our code
      c1f7406d
  2. 17 Sep, 2021 2 commits
    • Mathieu Tillet's avatar
      Load D16 omega scan as histograms · b9d851e9
      Mathieu Tillet authored
      Because of compatibility reasons for wrongly fomatted data, omega scans
      from D16 need to be loaded as histogram instead of point data. This
      requires in turn some adjustements to existing algorithm using this kind
      of data.
      b9d851e9
    • Mathieu Tillet's avatar
      Check for property before adding it · 78ca36c3
      Mathieu Tillet authored
      When loading metadata, check if a property is already present before
      trying to add it, so that the loading can carry on with a simple warning
      instead of failing altogether.
      78ca36c3
  3. 16 Sep, 2021 5 commits
  4. 15 Sep, 2021 2 commits
    • Danny Hindson's avatar
      Extend tests to check sort order of events · 972e88a7
      Danny Hindson authored
      972e88a7
    • Danny Hindson's avatar
      Handle case where detector doesn't have a workspace index · fc91dd56
      Danny Hindson authored
      The unit tests SetCrystalLocationTest, LoadEventNexusTest were failing due to
      some detectors in the input nexus file not having a corresponding workspace
      index. This showed up as the pixelID_to_wi_vector vector having
      std::numeric_limits<size_t>::max() as the wi value
      I've added check that wi<numEventLists before trying to retrieve the spectrum
      for wi which is the same check that's done elsewhere in ProcessBankData.cpp
      
      If the file BSS_11841_event.nxs had been loaded with compression on
      this would have caused a crash even before my fix to the sort order
      fc91dd56
  5. 14 Sep, 2021 1 commit
    • Danny Hindson's avatar
      Fix problem with sorting of events · 51203621
      Danny Hindson authored
      The LoadEventNexus algorithm is run without compression and the events
      in the Nexus file are not already sorted by pulse time, the algorithm
      is incorrectly labelling them as sorted by pulse time. This change fixes
      the problem by always looping through the "used" detectors even if
      loading without compression
      This problem was causing FilterByTime to incorrectly slice up an event
      file by time. A lot of events were assigned to the last second of a run
      when slicing by time
      51203621
  6. 13 Sep, 2021 7 commits
  7. 08 Sep, 2021 5 commits
  8. 07 Sep, 2021 1 commit
  9. 06 Sep, 2021 1 commit
  10. 24 Aug, 2021 1 commit
  11. 23 Aug, 2021 10 commits
  12. 20 Aug, 2021 2 commits
  13. 19 Aug, 2021 1 commit