GitLab

Fixes instances with missing assignment operator or copy constructor.
These are dangerous cases with dynamic memory as it's not obvious what
will happen, but the compiler will try anyway.

In many cases we can simply switch to unique_ptr or disable the copy
when it makes sense. But one or two cases required additional thought.

This fixes several memory leaks or sources of corruption if the fields
fall out of sync

These are various places where cppcheck now understands c++-17, or we
have improve our code

Because of compatibility reasons for wrongly fomatted data, omega scans
from D16 need to be loaded as histogram instead of point data. This
requires in turn some adjustements to existing algorithm using this kind
of data.

When loading metadata, check if a property is already present before
trying to add it, so that the loading can carry on with a simple warning
instead of failing altogether.

Modernises the codebase from nested workspaces to modern form. E.g.:

namespace A{
namespace B {}
}

Becomes
namespace A::B{
}

This will allow us to specify in the coding standards to prefer the
simple form instead

The unit tests SetCrystalLocationTest, LoadEventNexusTest were failing due to
some detectors in the input nexus file not having a corresponding workspace
index. This showed up as the pixelID_to_wi_vector vector having
std::numeric_limits<size_t>::max() as the wi value
I've added check that wi<numEventLists before trying to retrieve the spectrum
for wi which is the same check that's done elsewhere in ProcessBankData.cpp

If the file BSS_11841_event.nxs had been loaded with compression on
this would have caused a crash even before my fix to the sort order

The LoadEventNexus algorithm is run without compression and the events
in the Nexus file are not already sorted by pulse time, the algorithm
is incorrectly labelling them as sorted by pulse time. This change fixes
the problem by always looping through the "used" detectors even if
loading without compression
This problem was causing FilterByTime to incorrectly slice up an event
file by time. A lot of events were assigned to the last second of a run
when slicing by time

Fixes clang-tidy not recognising the access to the debug string, which
was protected behind the macro

Changes any non-const pointers which can be const qualified. This should
help especially with cppcheck, as the latter is very sensitive to this
change

Removes instances of std::move where:
- We have a constant argument
- For trivial types
- For cr-types

Replaces const refs with std::move, so that the compiler can choose
between copy elision, refs or a cheap move

Fixes many pass-by-val instances by replacing them with by-ref

* [CANSAS] remove dead code

* [CANSAS] append spectra as <SASdata> entries

* [CANSAS] >1 histogram workspace can be exported

* [CANSAS] create <SASData> of particular histogram

* [CANSAS] loop over all histograms

* [CANSAS] possibility to change filename

* [CANSAS] change filename for histograms

* [CANSAS] axis value and unit if not spectrum axis

* [CANSAS] mention OneSpectrumPerFile in doc

* [CANSAS] unit test for OneSpectrumPerFile

* [CANSAS] solve bug when no extension provided

* [CANSAS] add case for text axis

* [CANSAS] add case for bin edge axis

* [SAVEASCII] handle text and bin edge axis

* [SAVEASCII] alphabetic order

* [SAVEASCII] formatting

* [CANSAS] formatting

* [CANSAS] formatting

* complete unit tests for save cansas v2

* unit tests for one spectrum per file for ascii

* no scientific notation for the file names

* added relase note
Co-authored-by: gvardany <gagikvar@gmail.com>

Co-authored-by: Silke Schomann <74243814+SilkeSchomann@users.noreply.github.com>