GitLab

Fixes instances with missing assignment operator or copy constructor.
These are dangerous cases with dynamic memory as it's not obvious what
will happen, but the compiler will try anyway.

In many cases we can simply switch to unique_ptr or disable the copy
when it makes sense. But one or two cases required additional thought.

This fixes several memory leaks or sources of corruption if the fields
fall out of sync

Modernises the codebase from nested workspaces to modern form. E.g.:

namespace A{
namespace B {}
}

Becomes
namespace A::B{
}

This will allow us to specify in the coding standards to prefer the
simple form instead

The unit tests SetCrystalLocationTest, LoadEventNexusTest were failing due to
some detectors in the input nexus file not having a corresponding workspace
index. This showed up as the pixelID_to_wi_vector vector having
std::numeric_limits<size_t>::max() as the wi value
I've added check that wi<numEventLists before trying to retrieve the spectrum
for wi which is the same check that's done elsewhere in ProcessBankData.cpp

If the file BSS_11841_event.nxs had been loaded with compression on
this would have caused a crash even before my fix to the sort order

The LoadEventNexus algorithm is run without compression and the events
in the Nexus file are not already sorted by pulse time, the algorithm
is incorrectly labelling them as sorted by pulse time. This change fixes
the problem by always looping through the "used" detectors even if
loading without compression
This problem was causing FilterByTime to incorrectly slice up an event
file by time. A lot of events were assigned to the last second of a run
when slicing by time

Giovanni Di Siena authored Mar 31, 2020 and Gigg, Martyn Anthony committed Apr 07, 2020

In places other substitutions have been made, e.g
Clang does not yet specialize std::shared_ptr for T[]. Vector
has been used instead. The operator[] methods were incorrectly
marked const but returning a non-const reference - this has been fixed.
Refs #25842

Runs clang-tidy pass by ref across the codebase to fix-up various
warnings we are seeing in cppcheck

Also updated class_maker.py

Rather than doing foreach event: getpulse
foreach pulse: foreach eventinpulse

Mostly done by rolling back the changes that were made

Historic files can have this case. We change the local copy of logs to contain 1s to modernize them

Remove a check performed on individual events to account for this special case

Update copyright headers in all files

Squashed commit of the following:

* First version of a script to manage copyright statements

re #23468

* Neatened up script, added comments

re #23488

* move script to tools directory

re #23488

* small script changes and a couple of manual file changes

re #23488

* Minor chnage to whitespace detection in regex

re #23488

* Add an excluded directory

re #23488

* remove a repeasted copyright statement in a file

re #23488

* Don't comsume the comment end if it is on the same line

re #23488

* fix error in new copright parsing

re #23488

* remove double copyrifght entry

re #23488

* Improve handling of old copyrights at the start of comments

re #23488

* remove empty comments re #23488

* exclude gsoapgenerated directories

re #23488

* Sort out greedy line matching re #23488

* improve empty comment removal

re #23488

* improv...

Update to clang-format-5 and reformat the codebase 

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

We could just ignore invalid pixels, but given that the range of pixels being
used should now be correct this would indicates a coding error, so I've made
it throw instead.