GitLab

Fixes instances with missing assignment operator or copy constructor.
These are dangerous cases with dynamic memory as it's not obvious what
will happen, but the compiler will try anyway.

In many cases we can simply switch to unique_ptr or disable the copy
when it makes sense. But one or two cases required additional thought.

This fixes several memory leaks or sources of corruption if the fields
fall out of sync

Modernises the codebase from nested workspaces to modern form. E.g.:

namespace A{
namespace B {}
}

Becomes
namespace A::B{
}

This will allow us to specify in the coding standards to prefer the
simple form instead

Add an option to load all the logs in a nexus event file, instead of
only those approved by LoadNexusLogs, which are not nearly enough for
ILL's usage.

C4996. Warning that std::shared_ptr::unique() has been deprecated
Added a suppression to the MSVCSetup.cmake file. This is a bit of
a stop gap while an alternative solution is investigated

C4250. Warning that Algorithm and all the derived classes inherit
various methods "by dominance"
PropertyManagerOwner has been added to the Algorithm class by composition
instead of by inheritance which removes the diamond

Lots of instances of IAlgorithm_sptr type have been replaced with
"auto" to provide some extra flexibility around the arrangement of
the class\interface hierarchy in future

Also remove a couple of references to PropertyManagerOwner in case
its removed in future (merged into Algorithm)

According to the Nexus standard, if the offset is not present, it implies
the offset is and absolute timestamp, which is relative to the start of
Unix epoch (https://manual.nexusformat.org/classes/base_classes/NXlog.html)

So instead fo throwing an error, we use unix epoch.

Expose m_fileInfo from NexusFileLoader

Giovanni Di Siena authored Mar 31, 2020 and Gigg, Martyn Anthony committed Apr 07, 2020

In places other substitutions have been made, e.g
Clang does not yet specialize std::shared_ptr for T[]. Vector
has been used instead. The operator[] methods were incorrectly
marked const but returning a non-const reference - this has been fixed.
Refs #25842

Runs clang-tidy pass by ref across the codebase to fix-up various
warnings we are seeing in cppcheck

Also updated class_maker.py

Reuse map from NeXus file getEntries prevents creation and destruction
of std::map
addressing clang-format

It defaults to 500 bins.
This allows event data to be plotted without rebinning first.
This is a change from before when it would all be in one bin.
It does not change the underlying data that remains in events.

Includes unit test, and doc changes.

re #27319