Should now have no more force IDF parameter reads. You can do everything via the quick_explicit.

We need a way to pass correction strategies into quick rather than having it rely on the IDF definitions contained within. Wrapping up the algorithm calls so that they can be partially applied outside of quick is the most sensible way to do this. The new system tests are currently passing prior to making the change of swapping this functionality in.

To help with backwards compatibility, I really don't want to break anything dependent on quick at this stage (including the reflectometry gui), so I want to leave that function API intact. Instead, I introduce a new function called quick_explicit, which quick will call. 

Old tests checked things like coAdd. These are no longer required.

This assert method is not supported cross platform.

Use assertTrue instead.

This is only necessary while quick and auxiliary modules are scripts. This will change in the near future.

Some other refactoring work here around the multi detector quick routes.

Simplify and remove ADS usages.

Start replacing transmission correction logic with more distilled version.

OSX didn't like a std::ofstream being given a const std::string, so i've added .c_str() to all calls to getTestFileName() within an ofstream constructor

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

The calculation of how much was skipped was wrong as i was skipping over lines that were neither data or invalid wihtout taking note of them, a new conter was added - validRows - in order to keep track of how many valid lines there have been consecutively (data or not). This is then used instead of rowsToMatch when calculating numToSkip.

Corrected spelling of "Column" from "Collumn" in many places.

Fixed the bad line check to allow + and - as it had not been updated when they were classed as allowed leading characters

Refactored some of the unit test in order to allow the tests that don't use SaveAscii directly to access a correct absolute path.

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Signed-off-by: Karl Palmen <karl.palmen@stfc.ac.uk>

Refs #7912

Minor modifications also required to convert_to_wavelength.

processheader() used to get called after checking the base number of collumns, which was what was cusing the error.

processheader() is now called before setting the base number of collumns and will set the base number of columns as it checks, but only if the user doesn't specifiy a number of columns to skip. processheader() will check for a number of valid lines with the same number of columns (between 2 and 4 inclusive), skipping over and commented or blank lines, and resetting the matching counter when it hits an invalid line of any sort.

I'm leaving coAdd in the script for now, although the new convert_to_wavelength code will actually do the job of this code. coAdd actually does a lot of different and bizarre things in a single method, including StartLiveData, which is not yet converted by convert_to_wavelength as the current implementation of coAdd requires 'magic' decision making depending upon the type and format of the 'run' argument as well as the current state of the ADS etc.

The script is littered with these. Will take more work to get rid of them all.

Re #2389