GitLab

Based on review comments, revert the isHistogramData method to its
original form without any parameters to avoid encouraging creation
of matrix workspaces containing histograms with mix of xModes
Create private function instead that allows a specific histogram to
be checked

The unit test suite MonteCarloAbsorptionTest has occasionally been failing
with an access violation on Jenkins. I've been able to track this down to
the test Lambda_StepSize_Two_Linear_Interpolation which was failing

I can reproduce this locally by modifying the test to repeat 1000 times
and it eventually fails. Although the access violation occurs in a couple
of different places:
a) the y() or e() vector in the 0th histogram is sometimes empty once the
MonteCarloAbsorption algorithm completes which causes some of the test asserts
to fall over because they assume y(0).front() or e(0).front
b) sometimes the code in MonteCarloAbsorption itself has an access violation
when yIndexOfX returns an index out of range of the histogram

Both problems happen in the multi-threaded code in MonteCarloAbsorption and
it seems to be the interaction between the call to MatrixWorkspace::yIndexOfX
and the code that updates a histogram with interpolated results via
MatrixWorkspace::setHistogram. Something in these two functions isn't threadsafe
I found that yIndexOfX calls IsHistogramData() which checks the 0th
histogram in the workspcae even if the MonteCarloAbsorption code is
processing the 1st, 2nd etc workspace
I think if the 0th histogram is in the process of being updated by another
thread then yIndexOfX can fail or else the setHistogram call fails.
I have done two changes:
- only call yIndexOfX once (there was a redundant 2nd call)
- I have modified yIndexOfX so it takes an additional histogram index parameter.
This allows me to keep each MonteCarloAbsorption thread interacting with a
single histogram only. I have defaulted the new parameter to zero so other
code behaves as before

Giovanni Di Siena authored Mar 31, 2020 and Gigg, Martyn Anthony committed Apr 07, 2020

In places other substitutions have been made, e.g
Clang does not yet specialize std::shared_ptr for T[]. Vector
has been used instead. The operator[] methods were incorrectly
marked const but returning a non-const reference - this has been fixed.
Refs #25842

Also updated class_maker.py

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Steven Hahn <hahnse@ornl.gov>

Signed-off-by: Harriet Brown <harriet.brown@stfc.ac.uk>

This commit replaces all header guards in API with #pragma once

- Adds Python unit test for export
- Adds a `hasAnyMaskedBins` call in the MatrixWorkspace unit tests

Streamed data assumes spectra numbers start at zero.

No definition provided, so just a link-time error waiting to happen.

This is based on the prototype derived from the meeting at the DMSC last December.

The workflow is as follows:
  - Pool all events received from the Kafka stream into a single buffer
  - When the buffer is to be flushed (i.e. events populated in the EventWorkspace):
    - Parallel sort the event buffer by the detector ID/workspace index
    - Determine group boundaries
    - Parallel insert events into EventWorkspace

Also included is the optimisation of using a spec to ID mapping based on
a vector rather than map.
This provides better performance during the initial event buffering
(where this lookup is made).

Initial benchamrking shows 25M events is a intermediate buffer threshold
for LOKI (9 banks) at 10^7 events per second.
This manages to maintain well over 14Hz pulse rate (with no post
processing).

It is unused as users how gone in a different direction
with the project.
Refs #26223

Remove raw owning pointers from API tests

Add optional arg to YUnitLabel to return axis label with Latex
syntax. Remove code that did similiar in Python.

Use lock in MatrixWorkspace::isCommonBins() to stop a thread returning
the cached isCommonBinsFlag while another thread may still be updating
its value.

Re #24292