This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. 25 Mar, 2020 4 commits
  2. 20 Mar, 2020 1 commit
  3. 19 Mar, 2020 1 commit
  4. 16 Mar, 2020 1 commit
    • Danny Hindson's avatar
      Further work on applying cmake GenerateExportHeader · a8c3109c
      Danny Hindson authored
      Apply change to insert export macros into class definition using cmake GenerateExportHeader
      feature to 3 more projects: API, Crystal and CurveFitting
      Have replaced DllExport with the cmake macro except in these places:
      
      a) class templates - the definitions of class template member functions need to be in the
      same unit as the declaration so dllimport gives a compilation error in the client code
      (C2491 in VS) eg SingleValueParameter, SingleValueParameterParser
      b) headers which are in a project but aren't included by any .cpp units in the project
      eg IBackgroundFunction.h, ICatalogInfoService.h. In these cases I've removed the DLLExport
      attribute completely
      
      For the API target there were a couple of special cases\extras:
      
      API has some conditional use of the extern keyword to control instantiation of template
      classes. This has been inserted into the automatically created dllconfig.h using a cmake
      switch that allows some custom content to be appended to the end of the file. Few of the
      targets require this so I've added a boolean parameter to the wrapper function to handle
      this GENERATE_MANTID_EXPORT_HEADER
      
      I also had to add explicit include directories to PythonInterfaceCore where it imports an
      API target header (in the unit ExtractWorkspace.h) without having API as a dependency
      a8c3109c
  5. 11 Mar, 2020 2 commits
  6. 10 Mar, 2020 2 commits
  7. 09 Mar, 2020 4 commits
  8. 06 Mar, 2020 2 commits
  9. 05 Mar, 2020 4 commits
  10. 28 Feb, 2020 1 commit
    • David Fairbrother's avatar
      Re #28119 Append bad index to out of range exception · 4e871df4
      David Fairbrother authored
      Updates the IndexType to have a new method to convert to a string, this
      reduction in strict type safety could mean developers could abuse
      SpectrumIndex -> String conversions. However, it enables us to print a
      string representation of an index, such as if we need to say index x is
      out of range.
      
      Previously, the at() access on the IndexProperty map would throw with an
      invalid key message. This is useless for anyone who is trying to Mask a
      range of specra (such as 500), as you have to guess if the min / max or
      a middle value was bad.
      4e871df4
  11. 16 Jan, 2020 2 commits
  12. 28 Nov, 2019 1 commit
    • Martyn Gigg's avatar
      Accept OrientedLattice by unique_ptr · 424fc625
      Martyn Gigg authored
      The overwhelming use case for this method is to
      take ownership of a lattice object into Sample.
      Using unique_ptr clarifies that this is happening
      at the call site and forces a caller to make copy
      if that is truly the desired behaviour. The old code
      make a copy internally but this was not obvious
      from the method call.
      424fc625
  13. 20 Nov, 2019 1 commit
  14. 18 Nov, 2019 1 commit
  15. 08 Nov, 2019 1 commit
  16. 22 Aug, 2019 1 commit
  17. 13 Aug, 2019 1 commit
  18. 08 Aug, 2019 1 commit
  19. 07 Aug, 2019 3 commits
  20. 05 Aug, 2019 1 commit
  21. 30 Jul, 2019 1 commit
  22. 26 Jul, 2019 1 commit
  23. 25 Jul, 2019 3 commits