This project is mirrored from https://github.com/mantidproject/mantid.git. Pull mirroring updated .
  1. 25 Mar, 2020 1 commit
  2. 24 Mar, 2020 1 commit
  3. 23 Mar, 2020 1 commit
  4. 20 Mar, 2020 1 commit
  5. 16 Mar, 2020 1 commit
    • Danny Hindson's avatar
      Further work on applying cmake GenerateExportHeader · a8c3109c
      Danny Hindson authored
      Apply change to insert export macros into class definition using cmake GenerateExportHeader
      feature to 3 more projects: API, Crystal and CurveFitting
      Have replaced DllExport with the cmake macro except in these places:
      
      a) class templates - the definitions of class template member functions need to be in the
      same unit as the declaration so dllimport gives a compilation error in the client code
      (C2491 in VS) eg SingleValueParameter, SingleValueParameterParser
      b) headers which are in a project but aren't included by any .cpp units in the project
      eg IBackgroundFunction.h, ICatalogInfoService.h. In these cases I've removed the DLLExport
      attribute completely
      
      For the API target there were a couple of special cases\extras:
      
      API has some conditional use of the extern keyword to control instantiation of template
      classes. This has been inserted into the automatically created dllconfig.h using a cmake
      switch that allows some custom content to be appended to the end of the file. Few of the
      targets require this so I've added a boolean parameter to the wrapper function to handle
      this GENERATE_MANTID_EXPORT_HEADER
      
      I also had to add explicit include directories to PythonInterfaceCore where it imports an
      API target header (in the unit ExtractWorkspace.h) without having API as a dependency
      a8c3109c
  6. 13 Mar, 2020 1 commit
  7. 10 Mar, 2020 4 commits
  8. 06 Mar, 2020 6 commits
  9. 05 Mar, 2020 4 commits
    • Harriet Brown's avatar
      Remove header guards from tcc files in API · c7347d33
      Harriet Brown authored
      This commit removes header guards from tcc files that was missed in search script
      c7347d33
    • Danny Hindson's avatar
      Fix problems with setting YErr columns on table workspace · 77b9c037
      Danny Hindson authored
      This change fixes a problem in Workbench when setting columns to YErr
      Previously this only worked if all Y columns had an associated YErr column. If that
      wasn't the case then the associations between Y and YErr cols got mixed up
      I have saved the link between the YErr and Y column into the C++ table workspace
      object via changes to ITableWorkspace and the Column class
      I've also modified the model\view\presenter for the table workspace to set and get
      the link via the ITableWorkspace interface
      The code in marked_columns.py has been modified to remove the _add function because
      the logic required for adding x, y and yerr was sufficiently different that trying
      to push them through a common _add function was obscuring the code
      Finally I've removed the labelindex from the ErrorColumn object in the python code
      because it can be worked out on the fly (and I didn't want to have to save this also
      into the C++ table workspace in addition to the linked column index)
      
      As part of the test updates I have removed the test
      TableWorkspaceDisplayModelTest.test_initialise_marked_columns_yerr_before_y_doesnt_mark_yerr
      because we do require the ability to add a yerr column before the corresponding y column
      The model gets refreshed whenever the C++ table workspace is updated (eg when the type of a column
      is updated) as part of a replace_workspace call. The model __init__ function builds up the column
      set left to right and a user may have set up a Y err column which is to the left of the corresponding
      Y column.
      77b9c037
    • mantid-builder's avatar
      clang-format PR28233 123d8782 · 5d34f7bf
      mantid-builder authored
      
      
      Signed-off-by: default avatarHarriet Brown <harriet.brown@stfc.ac.uk>
      5d34f7bf
    • Harriet Brown's avatar
      Repalce header guards in API with pragma once · 123d8782
      Harriet Brown authored
      This commit replaces all header guards in API with #pragma once
      123d8782
  10. 31 Jan, 2020 1 commit
  11. 16 Jan, 2020 2 commits
  12. 09 Jan, 2020 1 commit
  13. 18 Dec, 2019 1 commit
  14. 14 Dec, 2019 1 commit
  15. 13 Dec, 2019 1 commit
  16. 04 Dec, 2019 1 commit
  17. 28 Nov, 2019 1 commit
    • Martyn Gigg's avatar
      Accept OrientedLattice by unique_ptr · 424fc625
      Martyn Gigg authored
      The overwhelming use case for this method is to
      take ownership of a lattice object into Sample.
      Using unique_ptr clarifies that this is happening
      at the call site and forces a caller to make copy
      if that is truly the desired behaviour. The old code
      make a copy internally but this was not obvious
      from the method call.
      424fc625
  18. 20 Nov, 2019 1 commit
  19. 18 Nov, 2019 1 commit
  20. 08 Nov, 2019 1 commit
  21. 18 Oct, 2019 1 commit
  22. 27 Sep, 2019 2 commits
  23. 23 Sep, 2019 1 commit
  24. 04 Sep, 2019 2 commits
    • Owen Arnold's avatar
      Fix bad merge and exports · 4b311737
      Owen Arnold authored
      4b311737
    • Owen Arnold's avatar
      File production seems to be OK · 6b68a103
      Owen Arnold authored
      Main change here is preventing LoadNexusProcessed from running the
      instrument save when going via the ESS route.
      
      New problem is that LoadNexusProcessed does not attempt to look for new
      Geometry in Nexus as part of the loading, and therefore gives up when it
      shouldn't
      
      LoadNexusProcessed also annoyinly looking for group named "instrument",
      which we now do not adhere to.
      6b68a103
  25. 02 Sep, 2019 1 commit
    • Owen Arnold's avatar
      File production seems to be OK · e4e5ecaa
      Owen Arnold authored
      Main change here is preventing LoadNexusProcessed from running the
      instrument save when going via the ESS route.
      
      New problem is that LoadNexusProcessed does not attempt to look for new
      Geometry in Nexus as part of the loading, and therefore gives up when it
      shouldn't
      
      LoadNexusProcessed also annoyinly looking for group named "instrument",
      which we now do not adhere to.
      e4e5ecaa
  26. 28 Aug, 2019 1 commit