GitLab

The Xintegration widget, which control the integration scroll at the
bottom of the instrument view, should only appear when the workspace
needs it.

This was currently the case, but only if the instrument view was opened
with this workspace : changing the underlying workspace midway, as
intended by replaceWorkspace, was not managed.

Thus, the way the integration range is managed was changed to a more
concise and modular way, so that it is only hidden or shown when needed,
but exists in all cases.

Because that's better than loading degrees as radians

Also, 0 mod 360 = 0, not 360

- Add a proper shortcut
- Fix the bounding box not following the sector when moved, but updating
it
- Set new endAngle at creation
- Fix a bug where the topLeft corner drag was mismanaged due to a bad
variable
- Better check for angles and radii values

When not setting an integration scroll bar, instead of just not showing
it, rather not create it at all. This is mmore heavy handed, as it
implies checking for the existence of the object each time it is called,
but it is more reliable (as the non-created object cannot possibly
occupy any space on screen).

This solves the problem of the unclickable Render and Pick tabs.

When saving projects, the save has to register if the instrument window
has an integration scroll bar or not, so when it loaded the loader won't
attempt to add values to a non-existent bar, resulting in a segfault.
Also, it remembers the mask tube and mask pixel buttons being checked
and restores them to their previous state at loading, as for any other button.

Giovanni Di Siena authored Mar 31, 2020 and Gigg, Martyn Anthony committed Apr 07, 2020

In places other substitutions have been made, e.g
Clang does not yet specialize std::shared_ptr for T[]. Vector
has been used instead. The operator[] methods were incorrectly
marked const but returning a non-const reference - this has been fixed.
Refs #25842

Also updated class_maker.py