From fc3d1c57bf76b70b4ce64533c698844c950f6665 Mon Sep 17 00:00:00 2001
From: Federico Montesino Pouzols <federico.montesino-pouzols@stfc.ac.uk>
Date: Mon, 30 Mar 2015 12:29:14 +0100
Subject: [PATCH] sort lib Poco headers, remove/un-include unused ones, re
 #10637

---
 .../Algorithms/src/ReadGroupsFromFile.cpp     |  9 +++----
 .../src/GenerateGroupingPowder.cpp            | 10 +++----
 .../DataHandling/src/LoadCanSAS1D.cpp         |  8 +++---
 .../DataHandling/src/LoadCanSAS1D2.cpp        |  2 --
 .../src/LoadDetectorsGroupingFile.cpp         |  7 +++--
 .../DataHandling/src/LoadPreNexusMonitors.cpp | 23 ++++++++--------
 .../DataHandling/src/LoadSpiceXML2DDet.cpp    | 27 +++++++++----------
 .../DataHandling/src/SNSDataArchive.cpp       | 15 +++++------
 .../src/SaveDetectorsGrouping.cpp             | 21 ++++++++-------
 .../Framework/DataHandling/src/SaveMask.cpp   | 25 ++++++++---------
 10 files changed, 69 insertions(+), 78 deletions(-)

diff --git a/Code/Mantid/Framework/Algorithms/src/ReadGroupsFromFile.cpp b/Code/Mantid/Framework/Algorithms/src/ReadGroupsFromFile.cpp
index 9add9701867..c355b8564e8 100644
--- a/Code/Mantid/Framework/Algorithms/src/ReadGroupsFromFile.cpp
+++ b/Code/Mantid/Framework/Algorithms/src/ReadGroupsFromFile.cpp
@@ -2,26 +2,23 @@
 // Includes
 //----------------------------------------------------------------------
 #include <fstream>
+
 #include "MantidAlgorithms/ReadGroupsFromFile.h"
 #include "MantidAPI/FileProperty.h"
 #include "MantidAPI/InstrumentDataService.h"
 #include "MantidAPI/MatrixWorkspace.h"
 #include "MantidAPI/WorkspaceProperty.h"
+#include "MantidAPI/WorkspaceValidators.h"
 #include "MantidDataObjects/Workspace2D.h"
 #include "MantidKernel/ConfigService.h"
+#include "MantidKernel/ListValidator.h"
 #include "MantidKernel/System.h"
 
 // Poco XML Headers for Grouping File
 #include <Poco/DOM/Document.h>
 #include <Poco/DOM/DOMParser.h>
 #include <Poco/DOM/Element.h>
-#include <Poco/DOM/NodeFilter.h>
-#include <Poco/DOM/NodeIterator.h>
 #include <Poco/DOM/NodeList.h>
-#include <Poco/File.h>
-#include <Poco/Path.h>
-#include "MantidAPI/WorkspaceValidators.h"
-#include "MantidKernel/ListValidator.h"
 
 using namespace Mantid::API;
 using namespace Mantid::Kernel;
diff --git a/Code/Mantid/Framework/DataHandling/src/GenerateGroupingPowder.cpp b/Code/Mantid/Framework/DataHandling/src/GenerateGroupingPowder.cpp
index 5f5dcc24a65..d925a4fd7bd 100644
--- a/Code/Mantid/Framework/DataHandling/src/GenerateGroupingPowder.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/GenerateGroupingPowder.cpp
@@ -3,11 +3,11 @@
 #include "MantidAPI/FileProperty.h"
 #include "MantidKernel/BoundedValidator.h"
 
-#include "Poco/DOM/Document.h"
-#include "Poco/DOM/Element.h"
-#include "Poco/DOM/Text.h"
-#include "Poco/DOM/AutoPtr.h"
-#include "Poco/DOM/DOMWriter.h"
+#include <Poco/DOM/AutoPtr.h>
+#include <Poco/DOM/Document.h>
+#include <Poco/DOM/DOMWriter.h>
+#include <Poco/DOM/Element.h>
+#include <Poco/DOM/Text.h>
 
 #ifdef _MSC_VER
 // Disable a flood of warnings from Poco about inheriting from
diff --git a/Code/Mantid/Framework/DataHandling/src/LoadCanSAS1D.cpp b/Code/Mantid/Framework/DataHandling/src/LoadCanSAS1D.cpp
index b3066362340..c65700a0ab8 100644
--- a/Code/Mantid/Framework/DataHandling/src/LoadCanSAS1D.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/LoadCanSAS1D.cpp
@@ -10,13 +10,12 @@
 #include "MantidKernel/ConfigService.h"
 #include "MantidDataObjects/Workspace2D.h"
 
-#include <Poco/Path.h>
-#include <Poco/DOM/DOMParser.h>
+#include <Poco/AutoPtr.h>
 #include <Poco/DOM/Document.h>
+#include <Poco/DOM/DOMParser.h>
 #include <Poco/DOM/NodeList.h>
-#include <Poco/DOM/Text.h>
 #include <Poco/SAX/InputSource.h>
-#include <Poco/DOM/AutoPtr.h>
+
 
 #include <boost/lexical_cast.hpp>
 //-----------------------------------------------------------------------
@@ -26,7 +25,6 @@ using Poco::XML::Document;
 using Poco::XML::Element;
 using Poco::XML::NodeList;
 using Poco::XML::Node;
-using Poco::XML::Text;
 
 using namespace Mantid::Kernel;
 using namespace Mantid::API;
diff --git a/Code/Mantid/Framework/DataHandling/src/LoadCanSAS1D2.cpp b/Code/Mantid/Framework/DataHandling/src/LoadCanSAS1D2.cpp
index 378569dbbbb..eac27552493 100644
--- a/Code/Mantid/Framework/DataHandling/src/LoadCanSAS1D2.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/LoadCanSAS1D2.cpp
@@ -10,11 +10,9 @@
 #include "MantidKernel/ConfigService.h"
 #include "MantidDataObjects/Workspace2D.h"
 
-#include <Poco/Path.h>
 #include <Poco/DOM/DOMParser.h>
 #include <Poco/DOM/Document.h>
 #include <Poco/DOM/NodeList.h>
-#include <Poco/DOM/Text.h>
 
 #include <boost/lexical_cast.hpp>
 //-----------------------------------------------------------------------
diff --git a/Code/Mantid/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp b/Code/Mantid/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp
index 37f6b96c15a..5d7c46af5b8 100644
--- a/Code/Mantid/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp
@@ -1,3 +1,5 @@
+#include <sstream>
+
 #include "MantidDataHandling/LoadDetectorsGroupingFile.h"
 #include "MantidKernel/System.h"
 #include "MantidAPI/FileProperty.h"
@@ -17,12 +19,9 @@
 #include <Poco/DOM/NodeList.h>
 #include <Poco/DOM/NamedNodeMap.h>
 #include <Poco/Exception.h>
-#include <Poco/File.h>
 #include <Poco/Path.h>
 #include <Poco/String.h>
 
-#include <sstream>
-
 using namespace Mantid::Kernel;
 using namespace Mantid::API;
 
@@ -609,7 +608,7 @@ std::string LoadGroupXMLFile::getAttributeValueByName(Poco::XML::Node *pNode,
                                                       std::string attributename,
                                                       bool &found) {
   // 1. Init
-  Poco::XML::NamedNodeMap *att = pNode->attributes();
+  Poco::AutoPtr<Poco::XML::NamedNodeMap> att = pNode->attributes();
   found = false;
   std::string value = "";
 
diff --git a/Code/Mantid/Framework/DataHandling/src/LoadPreNexusMonitors.cpp b/Code/Mantid/Framework/DataHandling/src/LoadPreNexusMonitors.cpp
index d5246168f95..2e5a8078098 100644
--- a/Code/Mantid/Framework/DataHandling/src/LoadPreNexusMonitors.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/LoadPreNexusMonitors.cpp
@@ -1,29 +1,28 @@
+#include <cmath>
+#include <cstdlib>
+#include <fstream>
+#include <iostream>
+#include <iterator>
+
 #include "MantidDataHandling/LoadPreNexusMonitors.h"
 #include "MantidAPI/FileProperty.h"
 #include "MantidKernel/ConfigService.h"
 #include "MantidKernel/UnitFactory.h"
 #include "MantidKernel/BinaryFile.h"
 
-#include <Poco/Path.h>
-#include <Poco/File.h>
+#include <boost/lexical_cast.hpp>
+#include <boost/shared_array.hpp>
+
+#include <Poco/DOM/AutoPtr.h>
 #include <Poco/DOM/DOMParser.h>
 #include <Poco/DOM/Document.h>
 #include <Poco/DOM/Element.h>
 #include <Poco/DOM/NodeIterator.h>
 #include <Poco/DOM/NodeFilter.h>
 #include <Poco/DOM/NodeList.h>
-#include <Poco/DOM/AutoPtr.h>
+#include <Poco/Path.h>
 #include <Poco/SAX/InputSource.h>
 
-#include <boost/lexical_cast.hpp>
-#include <boost/shared_array.hpp>
-
-#include <fstream>
-#include <cmath>
-#include <iostream>
-#include <cstdlib>
-#include <iterator>
-
 namespace Mantid {
 namespace DataHandling {
 
diff --git a/Code/Mantid/Framework/DataHandling/src/LoadSpiceXML2DDet.cpp b/Code/Mantid/Framework/DataHandling/src/LoadSpiceXML2DDet.cpp
index 588e5422fc3..dd7120c63b5 100644
--- a/Code/Mantid/Framework/DataHandling/src/LoadSpiceXML2DDet.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/LoadSpiceXML2DDet.cpp
@@ -1,25 +1,24 @@
+#include <algorithm>
+#include <fstream>
+
 #include "MantidDataHandling/LoadSpiceXML2DDet.h"
 #include "MantidAPI/FileProperty.h"
 #include "MantidAPI/WorkspaceProperty.h"
 #include "MantidAPI/WorkspaceFactory.h"
 #include "MantidKernel/ArrayProperty.h"
 
-#include "Poco/SAX/InputSource.h"
-#include "Poco/DOM/Document.h"
-#include "Poco/DOM/DOMParser.h"
-#include "Poco/DOM/AutoPtr.h"
-
-#include "Poco/DOM/NodeIterator.h"
-#include "Poco/DOM/NodeFilter.h"
-
-#include "Poco/DOM/Node.h"
-#include "Poco/DOM/NodeList.h"
-#include "Poco/DOM/NamedNodeMap.h"
-
-#include <algorithm>
-#include <fstream>
 #include <boost/algorithm/string.hpp>
 
+#include <Poco/DOM/AutoPtr.h>
+#include <Poco/DOM/Document.h>
+#include <Poco/DOM/DOMParser.h>
+#include <Poco/DOM/NamedNodeMap.h>
+#include <Poco/DOM/Node.h>
+#include <Poco/DOM/NodeFilter.h>
+#include <Poco/DOM/NodeIterator.h>
+#include <Poco/DOM/NodeList.h>
+#include <Poco/SAX/InputSource.h>
+
 namespace Mantid {
 namespace DataHandling {
 
diff --git a/Code/Mantid/Framework/DataHandling/src/SNSDataArchive.cpp b/Code/Mantid/Framework/DataHandling/src/SNSDataArchive.cpp
index ca088cab0fa..694da9114c5 100644
--- a/Code/Mantid/Framework/DataHandling/src/SNSDataArchive.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/SNSDataArchive.cpp
@@ -1,25 +1,24 @@
 //----------------------------------------------------------------------
 // Includes
 //----------------------------------------------------------------------
+#include <iostream>
+#include <sstream>
+
 #include "MantidKernel/Logger.h"
 #include "MantidKernel/InternetHelper.h"
 #include "MantidKernel/Exception.h"
 #include "MantidDataHandling/SNSDataArchive.h"
 #include "MantidAPI/ArchiveSearchFactory.h"
 
-#include <Poco/File.h>
 #include <boost/algorithm/string.hpp>
+#include <boost/algorithm/string/predicate.hpp>
+
+#include <Poco/AutoPtr.h>
 #include <Poco/DOM/DOMParser.h>
 #include <Poco/DOM/Document.h>
 #include <Poco/DOM/Element.h>
-#include "Poco/SAX/InputSource.h"
+#include <Poco/SAX/InputSource.h>
 #include <Poco/DOM/NodeList.h>
-#include <Poco/DOM/NodeIterator.h>
-#include <boost/algorithm/string/predicate.hpp>
-#include "Poco/DOM/AutoPtr.h"
-
-#include <iostream>
-#include <sstream>
 
 
 namespace Mantid {
diff --git a/Code/Mantid/Framework/DataHandling/src/SaveDetectorsGrouping.cpp b/Code/Mantid/Framework/DataHandling/src/SaveDetectorsGrouping.cpp
index eb9c0e00040..3ad37864c68 100644
--- a/Code/Mantid/Framework/DataHandling/src/SaveDetectorsGrouping.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/SaveDetectorsGrouping.cpp
@@ -1,17 +1,18 @@
-#include "MantidDataHandling/SaveDetectorsGrouping.h"
-#include "MantidKernel/System.h"
+#include <algorithm>
+#include <fstream>
+#include <sstream>
+
 #include "MantidAPI/FileProperty.h"
 #include "MantidAPI/ISpectrum.h"
+#include "MantidDataHandling/SaveDetectorsGrouping.h"
+#include "MantidKernel/System.h"
 
-#include "fstream"
-#include "sstream"
-#include "algorithm"
+#include <Poco/DOM/AutoPtr.h>
+#include <Poco/DOM/Document.h>
+#include <Poco/DOM/DOMWriter.h>
+#include <Poco/DOM/Element.h>
+#include <Poco/DOM/Text.h>
 
-#include "Poco/DOM/Document.h"
-#include "Poco/DOM/Element.h"
-#include "Poco/DOM/Text.h"
-#include "Poco/DOM/AutoPtr.h"
-#include "Poco/DOM/DOMWriter.h"
 #ifdef _MSC_VER
 // Disable a flood of warnings from Poco about inheriting from
 // std::basic_istream
diff --git a/Code/Mantid/Framework/DataHandling/src/SaveMask.cpp b/Code/Mantid/Framework/DataHandling/src/SaveMask.cpp
index cbc31100b1e..22da9d34e66 100644
--- a/Code/Mantid/Framework/DataHandling/src/SaveMask.cpp
+++ b/Code/Mantid/Framework/DataHandling/src/SaveMask.cpp
@@ -1,19 +1,20 @@
-#include "MantidDataHandling/SaveMask.h"
-#include "MantidKernel/System.h"
-#include "MantidDataObjects/SpecialWorkspace2D.h"
+#include <fstream>
+#include <sstream>
+#include <algorithm>
+
 #include "MantidAPI/FileProperty.h"
 #include "MantidAPI/ISpectrum.h"
-
-#include "fstream"
-#include "sstream"
-#include "algorithm"
+#include "MantidDataHandling/SaveMask.h"
+#include "MantidDataObjects/SpecialWorkspace2D.h"
+#include "MantidKernel/System.h"
 
 #include <boost/shared_ptr.hpp>
-#include "Poco/DOM/Document.h"
-#include "Poco/DOM/Element.h"
-#include "Poco/DOM/Text.h"
-#include "Poco/DOM/AutoPtr.h"
-#include "Poco/DOM/DOMWriter.h"
+
+#include <Poco/DOM/Document.h>
+#include <Poco/DOM/Element.h>
+#include <Poco/DOM/Text.h>
+#include <Poco/DOM/AutoPtr.h>
+#include <Poco/DOM/DOMWriter.h>
 #ifdef _MSC_VER
 // Disable a flood of warnings from Poco about inheriting from
 // std::basic_istream
-- 
GitLab