Commit f85203cb authored by Whitfield, Ross's avatar Whitfield, Ross
Browse files

Fix some comments

parent 14ca16f2
......@@ -30,7 +30,6 @@ namespace DataObjects {
*/
class DLLExport LeanElasticPeak : public BasePeak {
public:
LeanElasticPeak();
LeanElasticPeak(const Mantid::Kernel::V3D &QSampleFrame);
LeanElasticPeak(const Mantid::Kernel::V3D &QSampleFrame,
......
......@@ -75,7 +75,7 @@ public:
*/
bool customSort() const override { return true; }
void sort(std::vector<std::pair<std::string, bool>> &criteria) override;
void sort(std::vector<ColumnAndDirection> &criteria) override;
int getNumberPeaks() const override;
std::string getConvention() const override;
......
......@@ -73,7 +73,7 @@ public:
*/
bool customSort() const override { return true; }
void sort(std::vector<std::pair<std::string, bool>> &criteria) override;
void sort(std::vector<ColumnAndDirection> &criteria) override;
int getNumberPeaks() const override;
std::string getConvention() const override;
......
......@@ -308,12 +308,11 @@ LeanElasticPeaksWorkspace::createPeakHKL(const V3D &HKL) const {
const auto &lattice = this->sample().getOrientedLattice();
const auto &goniometer = this->run().getGoniometer();
// Calculate qLab from q HKL. As per Busing and Levy 1967, q_lab_frame = 2pi *
// Goniometer * UB * HKL
// Calculate qSample from q HKL. As per Busing and Levy 1967, q_sample_frame =
// 2pi * UB * HKL
const V3D qSampleFrame = lattice.getUB() * HKL * 2 * M_PI;
// create a peak using the qLab frame
// This should calculate the detector positions too
// create a peak using the qSample frame
std::unique_ptr<IPeak> peak =
std::make_unique<LeanElasticPeak>(qSampleFrame, goniometer.getR());
// We need to set HKL separately to keep things consistent.
......
......@@ -195,7 +195,7 @@ public:
pw->addPeak(p4);
std::vector<std::pair<std::string, bool>> criteria;
// Sort by ascending wavelength then decending dspacing
// Sort by decending wavelength then decending dspacing
criteria.emplace_back(std::pair<std::string, bool>("wavelength", false));
criteria.emplace_back(std::pair<std::string, bool>("dspacing", false));
pw->sort(criteria);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment