diff --git a/Code/Mantid/Framework/PythonInterface/plugins/algorithms/Symmetrise.py b/Code/Mantid/Framework/PythonInterface/plugins/algorithms/Symmetrise.py index 3e5ecae529fc9fee4352b5d6c2646fc931bc0f85..563c56c6ccad12148ef4a99896e8c7f7c4a6ac8d 100644 --- a/Code/Mantid/Framework/PythonInterface/plugins/algorithms/Symmetrise.py +++ b/Code/Mantid/Framework/PythonInterface/plugins/algorithms/Symmetrise.py @@ -57,9 +57,6 @@ class Symmetrise(PythonAlgorithm): def PyExec(self): - from IndirectCommon import StartTime, EndTime - - StartTime('Symmetrise') self._setup() temp_ws_name = '__symm_temp' @@ -173,8 +170,6 @@ class Symmetrise(PythonAlgorithm): self.setProperty('OutputWorkspace', self._output_workspace) - EndTime('Symmetrise') - def validateInputs(self): """ diff --git a/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/InelasticIndirectReduction.py b/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/InelasticIndirectReduction.py index aee835a8773649cedb5f47404fe10da87841ed6c..39070394a695e4f5815bd9135966038d838d16d4 100644 --- a/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/InelasticIndirectReduction.py +++ b/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/InelasticIndirectReduction.py @@ -77,13 +77,10 @@ class InelasticIndirectReduction(DataProcessorAlgorithm): def PyExec(self): from mantid import config, logger - from IndirectCommon import StartTime, EndTime import inelastic_indirect_reducer self._setup() - StartTime('InelasticIndirectReduction') - # Setup reducer reducer = inelastic_indirect_reducer.IndirectReducer() @@ -157,8 +154,6 @@ class InelasticIndirectReduction(DataProcessorAlgorithm): if self._plot_type != 'none': self._plot() - EndTime('InelasticIndirectReduction') - def validateInputs(self): """ diff --git a/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/MSGDiffractionReduction.py b/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/MSGDiffractionReduction.py index 73e8140748acaa31165604c67f7784010f430bcc..ca4277dad752be530a67fd6c9b9c0b604bce23d4 100644 --- a/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/MSGDiffractionReduction.py +++ b/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/MSGDiffractionReduction.py @@ -77,11 +77,8 @@ class MSGDiffractionReduction(PythonAlgorithm): def PyExec(self): - from IndirectCommon import StartTime, EndTime from IndirectDiffractionReduction import MSGDiffractionReducer - StartTime('MSGDiffractionReduction') - input_files = self.getProperty('InputFiles').value sum_files = self.getProperty('SumFiles').value individual_grouping = self.getProperty('IndividualGrouping').value @@ -119,7 +116,5 @@ class MSGDiffractionReduction(PythonAlgorithm): GroupWorkspaces(InputWorkspaces=result_ws_list, OutputWorkspace=output_ws_group) self.setProperty('OutputWorkspace', output_ws_group) - EndTime('MSGDiffractionReduction') - AlgorithmFactory.subscribe(MSGDiffractionReduction) diff --git a/Code/Mantid/scripts/Inelastic/IndirectAbsCor.py b/Code/Mantid/scripts/Inelastic/IndirectAbsCor.py index bd2855548e4a6196cb2d27547ab29e7d28284c34..3f7b40f777eb10a18243316b4de8b0d6d37bb77c 100644 --- a/Code/Mantid/scripts/Inelastic/IndirectAbsCor.py +++ b/Code/Mantid/scripts/Inelastic/IndirectAbsCor.py @@ -193,25 +193,28 @@ def AbsRun(inputWS, geom, beam, ncan, size, density, sigs, siga, avar, Save): accWS = name + '_acc' fname = name + '_abs' + log_names = [item[0] for item in sample_logs] + log_values = [item[1] for item in sample_logs] + CreateWorkspace(OutputWorkspace=assWS, DataX=dataX, DataY=dataA1, NSpec=ndet, UnitX='Wavelength', VerticalAxisUnit=v_axis_unit, VerticalAxisValues=v_axis_values) - addSampleLogs(assWS, sample_logs) + AddSampleLogMultiple(Workspace=assWS, LogNames=log_names, LogValues=log_values) CreateWorkspace(OutputWorkspace=asscWS, DataX=dataX, DataY=dataA2, NSpec=ndet, UnitX='Wavelength', VerticalAxisUnit=v_axis_unit, VerticalAxisValues=v_axis_values) - addSampleLogs(asscWS, sample_logs) + AddSampleLogMultiple(Workspace=asscWS, LogNames=log_names, LogValues=log_values) CreateWorkspace(OutputWorkspace=acscWS, DataX=dataX, DataY=dataA3, NSpec=ndet, UnitX='Wavelength', VerticalAxisUnit=v_axis_unit, VerticalAxisValues=v_axis_values) - addSampleLogs(acscWS, sample_logs) + AddSampleLogMultiple(Workspace=acscWS, LogNames=log_names, LogValues=log_values) CreateWorkspace(OutputWorkspace=accWS, DataX=dataX, DataY=dataA4, NSpec=ndet, UnitX='Wavelength', VerticalAxisUnit=v_axis_unit, VerticalAxisValues=v_axis_values) - addSampleLogs(accWS, sample_logs) + AddSampleLogMultiple(Workspace=accWS, LogNames=log_names, LogValues=log_values) group = assWS + ',' + asscWS + ',' + acscWS + ',' + accWS GroupWorkspaces(InputWorkspaces=group, OutputWorkspace=fname) diff --git a/Code/Mantid/scripts/Inelastic/IndirectCommon.py b/Code/Mantid/scripts/Inelastic/IndirectCommon.py index 7804beeac9c0d789bfdf57db35304691f364d11c..b96219f3b30d0ad6eb8f76acbf3fcef637b0db26 100644 --- a/Code/Mantid/scripts/Inelastic/IndirectCommon.py +++ b/Code/Mantid/scripts/Inelastic/IndirectCommon.py @@ -545,23 +545,3 @@ def convertParametersToWorkspace(params_table, x_column, param_names, output_nam axis.setLabel(i, name) mtd[output_name].replaceAxis(1, axis) - -def addSampleLogs(ws, sample_logs): - """ - Add a dictionary of logs to a workspace. - - The type of the log is inferred by the type of the value passed to the log. - - @param ws - workspace to add logs too. - @param sample_logs - dictionary of logs to append to the workspace. - """ - - for key, value in sample_logs.iteritems(): - if isinstance(value, bool): - log_type = 'String' - elif isinstance(value, (int, long, float)): - log_type = 'Number' - else: - log_type = 'String' - - AddSampleLog(Workspace=ws, LogName=key, LogType=log_type, LogText=str(value)) diff --git a/Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py b/Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py index 9a66123552e0b9ace64f00bea93720ca52b2a47a..c258965efba5ec46a5ac556cd70b6135b829669d 100644 --- a/Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py +++ b/Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py @@ -202,8 +202,10 @@ def furyfitSeq(inputWS, func, ftype, startx, endx, spec_min=0, spec_max=None, in CopyLogs(InputWorkspace=inputWS, OutputWorkspace=fit_group) CopyLogs(InputWorkspace=inputWS, OutputWorkspace=result_workspace) - addSampleLogs(fit_group, sample_logs) - addSampleLogs(result_workspace, sample_logs) + log_names = [item[0] for item in sample_logs] + log_values = [item[1] for item in sample_logs] + AddSampleLogMultiple(Workspace=result_workspace, LogNames=log_names, LogValues=log_values) + AddSampleLogMultiple(Workspace=fit_group, LogNames=log_names, LogValues=log_values) if Save: save_workspaces = [result_workspace, fit_group] @@ -272,8 +274,10 @@ def furyfitMult(inputWS, function, ftype, startx, endx, spec_min=0, spec_max=Non CopyLogs(InputWorkspace=inputWS, OutputWorkspace=result_workspace) CopyLogs(InputWorkspace=inputWS, OutputWorkspace=fit_group) - addSampleLogs(result_workspace, sample_logs) - addSampleLogs(fit_group, sample_logs) + log_names = [item[0] for item in sample_logs] + log_values = [item[1] for item in sample_logs] + AddSampleLogMultiple(Workspace=result_workspace, LogNames=log_names, LogValues=log_values) + AddSampleLogMultiple(Workspace=fit_group, LogNames=log_names, LogValues=log_values) DeleteWorkspace(tmp_fit_workspace) diff --git a/Code/Mantid/scripts/test/IndirectCommonTests.py b/Code/Mantid/scripts/test/IndirectCommonTests.py index 48b88d94cdbcfd17c9ca79127b289d06d92d8704..a0bbe462f14254221715448ab0b8b70d7269affa 100644 --- a/Code/Mantid/scripts/test/IndirectCommonTests.py +++ b/Code/Mantid/scripts/test/IndirectCommonTests.py @@ -285,23 +285,6 @@ class IndirectCommonTests(unittest.TestCase): self.assert_matrix_workspace_dimensions(params_workspace.name(), expected_num_histograms=3, expected_blocksize=5) - def test_addSampleLogs(self): - ws = CreateSampleWorkspace() - logs = {} - logs['FloatLog'] = 3.149 - logs['IntLog'] = 42 - logs['StringLog'] = "A String Log" - logs['BooleanLog'] = True - - indirect_common.addSampleLogs(ws, logs) - - self.assert_logs_match_expected(ws.name(), logs) - - def test_addSampleLogs_empty_dict(self): - ws = CreateSampleWorkspace() - logs = {} - self.assert_does_not_raise(Exception, indirect_common.addSampleLogs, ws, logs) - #----------------------------------------------------------- # Custom assertion functions #-----------------------------------------------------------