refs #26544 cpp check for ALF view

qt/scientific_interfaces/Direct/ALFView_model.h

@@ -36,7 +36,6 @@ public:
 
 private:
   int m_numberOfTubesInAverage;
-  int m_currentRun;
 };
 
 } // namespace CustomInterfaces

qt/scientific_interfaces/Direct/ALFView_view.cpp

@@ -24,7 +24,7 @@ ALFView_view::ALFView_view(const std::string &instrument, QWidget *parent)
 }
 
 void ALFView_view::setUpInstrument(
-    std::string fileName,
+    std::string &fileName,
     std::vector<std::function<bool(std::map<std::string, bool>)>> &binders) {
 
   m_extractSingleTubeObservable = new Observable();

qt/scientific_interfaces/Direct/ALFView_view.h

@@ -32,7 +32,7 @@ public:
   void observeAverageTube(Observer *listner);
 
   void
-  setUpInstrument(const std::string fileName,
+  setUpInstrument(const std::string &fileName,
                   std::vector<std::function<bool(std::map<std::string, bool>)>>
                       &binders) override;
 

qt/scientific_interfaces/Direct/BaseInstrumentView.cpp

@@ -28,7 +28,7 @@ BaseInstrumentView::BaseInstrumentView(const std::string &instrument,
 }
 
 void MantidQt::CustomInterfaces::BaseInstrumentView::setUpInstrument(
-    const std::string fileName,
+    const std::string &fileName,
     std::vector<std::function<bool(std::map<std::string, bool>)>> &instrument) {
 
   (void)instrument;

qt/scientific_interfaces/Direct/BaseInstrumentView.h

@@ -42,7 +42,7 @@ public:
     return m_instrumentWidget;
   };
   virtual void
-  setUpInstrument(const std::string fileName,
+  setUpInstrument(const std::string &fileName,
                   std::vector<std::function<bool(std::map<std::string, bool>)>>
                       &instrument);
   virtual void addObserver(std::tuple<std::string, Observer *> &listener){};