From e25181113cdfd1be5806be25c8cf89953e5f4643 Mon Sep 17 00:00:00 2001
From: Gemma Guest <gemma.guest@stfc.ac.uk>
Date: Thu, 22 Aug 2019 13:56:54 +0100
Subject: [PATCH] Minor refactoring to improve notify function names

Re #26536
---
 .../ISISReflectometry/GUI/Batch/BatchPresenter.cpp        | 4 ++--
 .../ISISReflectometry/GUI/Batch/BatchPresenter.h          | 2 +-
 .../ISISReflectometry/GUI/Batch/IBatchPresenter.h         | 2 +-
 .../GUI/MainWindow/IMainWindowPresenter.h                 | 2 +-
 .../GUI/MainWindow/MainWindowPresenter.cpp                | 2 +-
 .../GUI/MainWindow/MainWindowPresenter.h                  | 2 +-
 .../ISISReflectometry/GUI/Runs/IRunsPresenter.h           | 2 +-
 .../ISISReflectometry/GUI/Runs/IRunsView.h                | 2 +-
 .../ISISReflectometry/GUI/Runs/QtRunsView.cpp             | 2 +-
 .../ISISReflectometry/GUI/Runs/RunsPresenter.cpp          | 8 ++++----
 .../ISISReflectometry/GUI/Runs/RunsPresenter.h            | 4 ++--
 .../ISISReflectometry/GUI/RunsTable/IRunsTableView.h      | 2 +-
 .../ISISReflectometry/GUI/RunsTable/QtRunsTableView.cpp   | 2 +-
 .../GUI/RunsTable/RunsTablePresenter.cpp                  | 4 ++--
 .../ISISReflectometry/GUI/RunsTable/RunsTablePresenter.h  | 2 +-
 .../test/ISISReflectometry/Batch/BatchPresenterTest.h     | 4 ++--
 .../MainWindow/MainWindowPresenterTest.h                  | 8 ++++----
 .../MainWindow/MockMainWindowPresenter.h                  | 2 +-
 .../test/ISISReflectometry/ReflMockObjects.h              | 4 ++--
 .../test/ISISReflectometry/Runs/RunsPresenterTest.h       | 8 ++++----
 .../RunsTable/RunsTablePresenterProcessingTest.h          | 4 ++--
 21 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/BatchPresenter.cpp b/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/BatchPresenter.cpp
index 47c6ffb2db7..ec7693099a5 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/BatchPresenter.cpp
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/BatchPresenter.cpp
@@ -75,9 +75,9 @@ void BatchPresenter::initInstrumentList() {
 
 bool BatchPresenter::requestClose() const { return true; }
 
-void BatchPresenter::notifyInstrumentChangedRequested(
+void BatchPresenter::notifyChangeInstrumentRequested(
     const std::string &instrumentName) {
-  m_mainPresenter->notifyInstrumentChangedRequested(instrumentName);
+  m_mainPresenter->notifyChangeInstrumentRequested(instrumentName);
 }
 
 void BatchPresenter::notifyInstrumentChanged(
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/BatchPresenter.h b/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/BatchPresenter.h
index 211ef620417..3312f52c30a 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/BatchPresenter.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/BatchPresenter.h
@@ -62,7 +62,7 @@ public:
   void notifyAutoreductionPaused() override;
   void notifyAutoreductionCompleted() override;
   void
-  notifyInstrumentChangedRequested(const std::string &instrumentName) override;
+  notifyChangeInstrumentRequested(const std::string &instrumentName) override;
   void notifyInstrumentChanged(const std::string &instrumentName) override;
   void notifyUpdateInstrumentRequested() override;
   void notifySettingsChanged() override;
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/IBatchPresenter.h b/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/IBatchPresenter.h
index 3196b64433e..77cc53b0804 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/IBatchPresenter.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/Batch/IBatchPresenter.h
@@ -38,7 +38,7 @@ public:
   virtual void notifyAutoreductionPaused() = 0;
   virtual void notifyAutoreductionCompleted() = 0;
   virtual void
-  notifyInstrumentChangedRequested(const std::string &instrumentName) = 0;
+  notifyChangeInstrumentRequested(const std::string &instrumentName) = 0;
   virtual void notifyInstrumentChanged(const std::string &instrumentName) = 0;
   virtual void notifyUpdateInstrumentRequested() = 0;
   virtual void notifySettingsChanged() = 0;
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/IMainWindowPresenter.h b/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/IMainWindowPresenter.h
index cadb4fab3ff..d1441b424c4 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/IMainWindowPresenter.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/IMainWindowPresenter.h
@@ -29,7 +29,7 @@ public:
   virtual void reductionResumed() = 0;
   virtual void reductionPaused() = 0;
   virtual void
-  notifyInstrumentChangedRequested(std::string const &instrumentName) = 0;
+  notifyChangeInstrumentRequested(std::string const &instrumentName) = 0;
   virtual void notifyUpdateInstrumentRequested() = 0;
   virtual Mantid::Geometry::Instrument_const_sptr instrument() const = 0;
   virtual std::string instrumentName() const = 0;
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.cpp b/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.cpp
index 3fa244e4874..edc022fe787 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.cpp
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.cpp
@@ -95,7 +95,7 @@ void MainWindowPresenter::reductionResumed() { disableSaveAndLoadBatch(); }
 // Called on autoreduction normal reduction
 void MainWindowPresenter::reductionPaused() { enableSaveAndLoadBatch(); }
 
-void MainWindowPresenter::notifyInstrumentChangedRequested(
+void MainWindowPresenter::notifyChangeInstrumentRequested(
     std::string const &instrumentName) {
   // Re-load instrument with the new name
   updateInstrument(instrumentName);
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.h b/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.h
index 89c4e491cdf..7effdf92ed7 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/MainWindow/MainWindowPresenter.h
@@ -49,7 +49,7 @@ public:
   void reductionResumed() override;
   void reductionPaused() override;
   void
-  notifyInstrumentChangedRequested(std::string const &instrumentName) override;
+  notifyChangeInstrumentRequested(std::string const &instrumentName) override;
   void notifyUpdateInstrumentRequested() override;
   Mantid::Geometry::Instrument_const_sptr instrument() const override;
   std::string instrumentName() const override;
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/IRunsPresenter.h b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/IRunsPresenter.h
index 1d874ad4afd..204c7087425 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/IRunsPresenter.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/IRunsPresenter.h
@@ -30,7 +30,7 @@ public:
   virtual RunsTable &mutableRunsTable() = 0;
 
   virtual void
-  notifyInstrumentChangedRequested(std::string const &instrumentName) = 0;
+  notifyChangeInstrumentRequested(std::string const &instrumentName) = 0;
   virtual void notifyReductionResumed() = 0;
   virtual void notifyReductionPaused() = 0;
   virtual void notifyRowStateChanged() = 0;
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/IRunsView.h b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/IRunsView.h
index cccfd0b6837..811c36cd2d0 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/IRunsView.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/IRunsView.h
@@ -36,7 +36,7 @@ public:
   virtual void notifyAutoreductionResumed() = 0;
   virtual void notifyAutoreductionPaused() = 0;
   virtual void notifyTransfer() = 0;
-  virtual void notifyInstrumentChangedRequested() = 0;
+  virtual void notifyChangeInstrumentRequested() = 0;
   virtual void notifyStartMonitor() = 0;
   virtual void notifyStopMonitor() = 0;
   virtual void notifyStartMonitorComplete() = 0;
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/QtRunsView.cpp b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/QtRunsView.cpp
index f891cede32d..3c42ac07548 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/QtRunsView.cpp
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/QtRunsView.cpp
@@ -271,7 +271,7 @@ void QtRunsView::onShowSearchContextMenuRequested(const QPoint &pos) {
 void QtRunsView::onInstrumentChanged(int index) {
   UNUSED_ARG(index);
   m_ui.textSearch->clear();
-  m_notifyee->notifyInstrumentChangedRequested();
+  m_notifyee->notifyChangeInstrumentRequested();
 }
 
 /**
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/RunsPresenter.cpp b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/RunsPresenter.cpp
index 9cbf9d2dcb3..2ca2849ff70 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/RunsPresenter.cpp
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/RunsPresenter.cpp
@@ -120,14 +120,14 @@ void RunsPresenter::notifyTransfer() {
   notifyRowStateChanged();
 }
 
-void RunsPresenter::notifyInstrumentChangedRequested() {
+void RunsPresenter::notifyChangeInstrumentRequested() {
   auto const instrumentName = m_view->getSearchInstrument();
-  m_mainPresenter->notifyInstrumentChangedRequested(instrumentName);
+  m_mainPresenter->notifyChangeInstrumentRequested(instrumentName);
 }
 
-void RunsPresenter::notifyInstrumentChangedRequested(
+void RunsPresenter::notifyChangeInstrumentRequested(
     std::string const &instrumentName) {
-  m_mainPresenter->notifyInstrumentChangedRequested(instrumentName);
+  m_mainPresenter->notifyChangeInstrumentRequested(instrumentName);
 }
 
 void RunsPresenter::notifyReductionResumed() {
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/RunsPresenter.h b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/RunsPresenter.h
index 25233dadf10..32072ea58d3 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/RunsPresenter.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/Runs/RunsPresenter.h
@@ -76,7 +76,7 @@ public:
   bool isAutoreducing() const override;
   int percentComplete() const override;
   void
-  notifyInstrumentChangedRequested(std::string const &instrumentName) override;
+  notifyChangeInstrumentRequested(std::string const &instrumentName) override;
   void notifyReductionResumed() override;
   void notifyReductionPaused() override;
   void notifyRowStateChanged() override;
@@ -100,7 +100,7 @@ public:
   void notifyAutoreductionResumed() override;
   void notifyAutoreductionPaused() override;
   void notifyTransfer() override;
-  void notifyInstrumentChangedRequested() override;
+  void notifyChangeInstrumentRequested() override;
   void notifyStartMonitor() override;
   void notifyStopMonitor() override;
   void notifyStartMonitorComplete() override;
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/IRunsTableView.h b/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/IRunsTableView.h
index 1be22316e1b..792b9dafc07 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/IRunsTableView.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/IRunsTableView.h
@@ -24,7 +24,7 @@ public:
   virtual void notifyDeleteRowRequested() = 0;
   virtual void notifyDeleteGroupRequested() = 0;
   virtual void notifyFilterChanged(std::string const &filterValue) = 0;
-  virtual void notifyInstrumentChangedRequested() = 0;
+  virtual void notifyChangeInstrumentRequested() = 0;
   virtual void notifyExpandAllRequested() = 0;
   virtual void notifyCollapseAllRequested() = 0;
   virtual void notifyPlotSelectedPressed() = 0;
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/QtRunsTableView.cpp b/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/QtRunsTableView.cpp
index 008490c75be..369bae47eb3 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/QtRunsTableView.cpp
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/QtRunsTableView.cpp
@@ -85,7 +85,7 @@ void QtRunsTableView::onFilterChanged(QString const &filter) {
 
 void QtRunsTableView::onInstrumentChanged(int index) {
   UNUSED_ARG(index);
-  m_notifyee->notifyInstrumentChangedRequested();
+  m_notifyee->notifyChangeInstrumentRequested();
 }
 
 std::string QtRunsTableView::getInstrumentName() const {
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/RunsTablePresenter.cpp b/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/RunsTablePresenter.cpp
index 0d4a3e9e0b7..150460227ea 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/RunsTablePresenter.cpp
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/RunsTablePresenter.cpp
@@ -237,9 +237,9 @@ void RunsTablePresenter::notifyFilterChanged(std::string const &filterString) {
   }
 }
 
-void RunsTablePresenter::notifyInstrumentChangedRequested() {
+void RunsTablePresenter::notifyChangeInstrumentRequested() {
   auto const instrumentName = m_view->getInstrumentName();
-  m_mainPresenter->notifyInstrumentChangedRequested(instrumentName);
+  m_mainPresenter->notifyChangeInstrumentRequested(instrumentName);
 }
 
 void RunsTablePresenter::notifyFilterReset() { m_view->resetFilterBox(); }
diff --git a/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/RunsTablePresenter.h b/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/RunsTablePresenter.h
index e9c7f6ae91b..4bd7fa6672c 100644
--- a/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/RunsTablePresenter.h
+++ b/qt/scientific_interfaces/ISISReflectometry/GUI/RunsTable/RunsTablePresenter.h
@@ -49,7 +49,7 @@ public:
   void notifyDeleteRowRequested() override;
   void notifyDeleteGroupRequested() override;
   void notifyFilterChanged(std::string const &filterValue) override;
-  void notifyInstrumentChangedRequested() override;
+  void notifyChangeInstrumentRequested() override;
   void notifyExpandAllRequested() override;
   void notifyCollapseAllRequested() override;
   void notifyPlotSelectedPressed() override;
diff --git a/qt/scientific_interfaces/test/ISISReflectometry/Batch/BatchPresenterTest.h b/qt/scientific_interfaces/test/ISISReflectometry/Batch/BatchPresenterTest.h
index d6fd51685b4..3331be1cd2b 100644
--- a/qt/scientific_interfaces/test/ISISReflectometry/Batch/BatchPresenterTest.h
+++ b/qt/scientific_interfaces/test/ISISReflectometry/Batch/BatchPresenterTest.h
@@ -64,9 +64,9 @@ public:
   void testMainPresenterUpdatedWhenInstrumentChangedRequested() {
     auto presenter = makePresenter();
     auto const instrument = std::string("POLREF");
-    EXPECT_CALL(m_mainPresenter, notifyInstrumentChangedRequested(instrument))
+    EXPECT_CALL(m_mainPresenter, notifyChangeInstrumentRequested(instrument))
         .Times(1);
-    presenter.notifyInstrumentChangedRequested(instrument);
+    presenter.notifyChangeInstrumentRequested(instrument);
     verifyAndClear();
   }
 
diff --git a/qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MainWindowPresenterTest.h b/qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MainWindowPresenterTest.h
index fd46fcb305f..23d6a8ea6c4 100644
--- a/qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MainWindowPresenterTest.h
+++ b/qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MainWindowPresenterTest.h
@@ -191,7 +191,7 @@ public:
   void testInstrumentChangedRequestedUpdatesInstrumentInModel() {
     auto presenter = makePresenter();
     auto const instrument = std::string("POLREF");
-    presenter.notifyInstrumentChangedRequested(instrument);
+    presenter.notifyChangeInstrumentRequested(instrument);
     TS_ASSERT_EQUALS(presenter.instrumentName(), instrument);
     verifyAndClear();
   }
@@ -203,14 +203,14 @@ public:
         .Times(1);
     EXPECT_CALL(*m_batchPresenters[1], notifyInstrumentChanged(instrument))
         .Times(1);
-    presenter.notifyInstrumentChangedRequested(instrument);
+    presenter.notifyChangeInstrumentRequested(instrument);
     verifyAndClear();
   }
 
   void testUpdateInstrumentRequestedUpdatesInstrumentInChildPresenters() {
     auto presenter = makePresenter();
     // must set the instrument to something valid first
-    presenter.notifyInstrumentChangedRequested("POLREF");
+    presenter.notifyChangeInstrumentRequested("POLREF");
     auto const instrument = presenter.instrumentName();
     EXPECT_CALL(*m_batchPresenters[0], notifyInstrumentChanged(instrument))
         .Times(1);
@@ -223,7 +223,7 @@ public:
   void testUpdateInstrumentRequestedDoesNotChangeInstrumentName() {
     auto presenter = makePresenter();
     // must set the instrument to something valid first
-    presenter.notifyInstrumentChangedRequested("POLREF");
+    presenter.notifyChangeInstrumentRequested("POLREF");
     auto const instrument = presenter.instrumentName();
     presenter.notifyUpdateInstrumentRequested();
     TS_ASSERT_EQUALS(presenter.instrumentName(), instrument);
diff --git a/qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MockMainWindowPresenter.h b/qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MockMainWindowPresenter.h
index d5a0fb68d95..2a9580837d1 100644
--- a/qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MockMainWindowPresenter.h
+++ b/qt/scientific_interfaces/test/ISISReflectometry/MainWindow/MockMainWindowPresenter.h
@@ -22,7 +22,7 @@ public:
   MOCK_METHOD0(notifyAutoreductionPaused, void());
   MOCK_METHOD0(reductionResumed, void());
   MOCK_METHOD0(reductionPaused, void());
-  MOCK_METHOD1(notifyInstrumentChangedRequested, void(std::string const &));
+  MOCK_METHOD1(notifyChangeInstrumentRequested, void(std::string const &));
   MOCK_METHOD0(notifyUpdateInstrumentRequested, void());
   MOCK_CONST_METHOD0(instrument, Mantid::Geometry::Instrument_const_sptr());
   MOCK_CONST_METHOD0(instrumentName, std::string());
diff --git a/qt/scientific_interfaces/test/ISISReflectometry/ReflMockObjects.h b/qt/scientific_interfaces/test/ISISReflectometry/ReflMockObjects.h
index 76d85c9a488..a3ab6aaf7d0 100644
--- a/qt/scientific_interfaces/test/ISISReflectometry/ReflMockObjects.h
+++ b/qt/scientific_interfaces/test/ISISReflectometry/ReflMockObjects.h
@@ -65,7 +65,7 @@ public:
   MOCK_METHOD0(anyBatchAutoreductionPaused, void());
   MOCK_METHOD0(reductionPaused, void());
 
-  MOCK_METHOD1(notifyInstrumentChangedRequested, void(const std::string &));
+  MOCK_METHOD1(notifyChangeInstrumentRequested, void(const std::string &));
   MOCK_METHOD1(notifyInstrumentChanged, void(const std::string &));
   MOCK_METHOD0(notifyUpdateInstrumentRequested, void());
   MOCK_METHOD0(notifyRestoreDefaultsRequested, void());
@@ -86,7 +86,7 @@ public:
   MOCK_METHOD0(initInstrumentList, void());
   MOCK_CONST_METHOD0(runsTable, RunsTable const &());
   MOCK_METHOD0(mutableRunsTable, RunsTable &());
-  MOCK_METHOD1(notifyInstrumentChangedRequested, void(std::string const &));
+  MOCK_METHOD1(notifyChangeInstrumentRequested, void(std::string const &));
   MOCK_METHOD0(notifyReductionResumed, void());
   MOCK_METHOD0(notifyReductionPaused, void());
   MOCK_METHOD0(notifyRowStateChanged, void());
diff --git a/qt/scientific_interfaces/test/ISISReflectometry/Runs/RunsPresenterTest.h b/qt/scientific_interfaces/test/ISISReflectometry/Runs/RunsPresenterTest.h
index b09ebf9e819..2a093d3a7d9 100644
--- a/qt/scientific_interfaces/test/ISISReflectometry/Runs/RunsPresenterTest.h
+++ b/qt/scientific_interfaces/test/ISISReflectometry/Runs/RunsPresenterTest.h
@@ -415,18 +415,18 @@ public:
     auto presenter = makePresenter();
     auto const instrument = std::string("TEST-instrumnet");
     expectSearchInstrument(instrument);
-    EXPECT_CALL(m_mainPresenter, notifyInstrumentChangedRequested(instrument))
+    EXPECT_CALL(m_mainPresenter, notifyChangeInstrumentRequested(instrument))
         .Times(1);
-    presenter.notifyInstrumentChangedRequested();
+    presenter.notifyChangeInstrumentRequested();
     verifyAndClear();
   }
 
   void testInstrumentChangedRequestedWithGivenNameNotifiesMainPresenter() {
     auto presenter = makePresenter();
     auto const instrument = std::string("TEST-instrumnet");
-    EXPECT_CALL(m_mainPresenter, notifyInstrumentChangedRequested(instrument))
+    EXPECT_CALL(m_mainPresenter, notifyChangeInstrumentRequested(instrument))
         .Times(1);
-    presenter.notifyInstrumentChangedRequested(instrument);
+    presenter.notifyChangeInstrumentRequested(instrument);
     verifyAndClear();
   }
 
diff --git a/qt/scientific_interfaces/test/ISISReflectometry/RunsTable/RunsTablePresenterProcessingTest.h b/qt/scientific_interfaces/test/ISISReflectometry/RunsTable/RunsTablePresenterProcessingTest.h
index aa126613d49..79eda5db93e 100644
--- a/qt/scientific_interfaces/test/ISISReflectometry/RunsTable/RunsTablePresenterProcessingTest.h
+++ b/qt/scientific_interfaces/test/ISISReflectometry/RunsTable/RunsTablePresenterProcessingTest.h
@@ -56,9 +56,9 @@ public:
     EXPECT_CALL(m_view, getInstrumentName())
         .Times(1)
         .WillOnce(Return(instrument));
-    EXPECT_CALL(m_mainPresenter, notifyInstrumentChangedRequested(instrument))
+    EXPECT_CALL(m_mainPresenter, notifyChangeInstrumentRequested(instrument))
         .Times(1);
-    presenter.notifyInstrumentChangedRequested();
+    presenter.notifyChangeInstrumentRequested();
     verifyAndClearExpectations();
   }
 
-- 
GitLab