Commit dbcb46d3 authored by Samuel Jones's avatar Samuel Jones
Browse files

Small GCC8 warning clear up

parent b84db52b
......@@ -39,6 +39,7 @@ public:
IndexProperty *clone() const override;
using Kernel::ArrayProperty<int64_t>::operator=;
using Kernel::ArrayProperty<int64_t>::operator const std::vector<int64_t> &;
bool isDefault() const override;
std::string isValid() const override;
......
......@@ -44,7 +44,6 @@
#include "MantidAPI/Algorithm.tcc"
using namespace Mantid::Kernel;
using VectorStringProperty = PropertyWithValue<std::vector<std::string>>;
namespace Mantid {
namespace API {
......
......@@ -55,7 +55,7 @@ public:
spice2d.initialize();
// No parameters have been set yet, so it should throw
TS_ASSERT_THROWS(spice2d.execute(), std::runtime_error);
TS_ASSERT_THROWS(spice2d.execute(), const std::runtime_error &);
// Set the file name
spice2d.setPropertyValue("Filename", inputFile);
......@@ -181,7 +181,7 @@ public:
spice2d.initialize();
// No parameters have been set yet, so it should throw
TS_ASSERT_THROWS(spice2d.execute(), std::runtime_error);
TS_ASSERT_THROWS(spice2d.execute(), const std::runtime_error &);
// Set the file name
spice2d.setPropertyValue("Filename", inputFile);
......
......@@ -81,7 +81,7 @@ public:
V3D(-5, 5, -15), V3D(5, -5, 15), V3D(5, 5, 15),
V3D(-5, 5, 15), V3D(-5, -5, 15)};
auto writer = SaveStl(path, triangle, vertices, ScaleUnits::metres);
TS_ASSERT_THROWS(writer.writeStl(), std::runtime_error);
TS_ASSERT_THROWS(writer.writeStl(), const std::runtime_error &);
TS_ASSERT(!Poco::File(path).exists());
}
......
......@@ -936,13 +936,13 @@ public:
detid_t numDetectors = 3;
TS_ASSERT_THROWS(loadInstrLocations(locations, numDetectors, true),
Exception::InstrumentDefinitionError);
const Exception::InstrumentDefinitionError &);
locations =
R"(<locations n-elements="3" name-count-start="5" name-count-increment="-7" name="det" />)";
TS_ASSERT_THROWS(loadInstrLocations(locations, numDetectors, true),
Exception::InstrumentDefinitionError);
const Exception::InstrumentDefinitionError &);
}
void testLocationsStaticValues() {
......
......@@ -109,7 +109,8 @@ private:
5, 100.0, 500.0, {1.0, 2.0, 3.0, 4.0, 5.0}, paramsType);
auto instrument = workspace->getInstrument();
ExperimentOptionDefaults experimentDefaults;
TS_ASSERT_THROWS(experimentDefaults.get(instrument), std::invalid_argument);
TS_ASSERT_THROWS(experimentDefaults.get(instrument),
const std::invalid_argument &);
}
};
......
......@@ -93,7 +93,8 @@ private:
5, 100.0, 500.0, {1.0, 2.0, 3.0, 4.0, 5.0}, paramsType);
auto instrument = workspace->getInstrument();
InstrumentOptionDefaults instrumentDefaults;
TS_ASSERT_THROWS(instrumentDefaults.get(instrument), std::invalid_argument);
TS_ASSERT_THROWS(instrumentDefaults.get(instrument),
const std::invalid_argument &);
}
};
......
......@@ -84,7 +84,7 @@ public:
create<Workspace2D>(2, Histogram(BinEdges{1, 2, 4})).release());
MantidAxes axes{pyAxes()};
TS_ASSERT_THROWS(axes.plot(ws, 2, "red", "mylabel"),
Python::ErrorAlreadySet);
const Python::ErrorAlreadySet &);
}
private:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment