From ad1976ae99a3548167ec22a95876148d6c641aba Mon Sep 17 00:00:00 2001
From: Nick Draper <nick.draper@stfc.ac.uk>
Date: Fri, 20 Mar 2020 16:42:47 +0000
Subject: [PATCH] Updates after Conor's review
---
Framework/API/src/Algorithm.cpp | 2 +-
Framework/API/src/AlgorithmProxy.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Framework/API/src/Algorithm.cpp b/Framework/API/src/Algorithm.cpp
index ad1bf7988f1..7ce5848fefd 100644
--- a/Framework/API/src/Algorithm.cpp
+++ b/Framework/API/src/Algorithm.cpp
@@ -723,7 +723,7 @@ bool Algorithm::executeInternal() {
}
catch (...) {
- // Execution
+ // Execution failed with an unknown exception object
setResultState(ResultState::Failed);
m_runningAsync = false;
diff --git a/Framework/API/src/AlgorithmProxy.cpp b/Framework/API/src/AlgorithmProxy.cpp
index b6439aa99f3..56e932af4cd 100644
--- a/Framework/API/src/AlgorithmProxy.cpp
+++ b/Framework/API/src/AlgorithmProxy.cpp
@@ -109,7 +109,7 @@ bool AlgorithmProxy::executeAsyncImpl(const Poco::Void &dummy) {
throw;
}
stopped();
- return (resultState() == ResultState::Success);
+ return isExecuted();
}
/// Gets the current execution state
--
GitLab